Merge lp://staging/~elementary-pantheon/switchboard/flowbox into lp://staging/~elementary-pantheon/switchboard/switchboard
Proposed by
Danielle Foré
Status: | Merged | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Approved by: | Danielle Foré | ||||||||||||
Approved revision: | 656 | ||||||||||||
Merged at revision: | 644 | ||||||||||||
Proposed branch: | lp://staging/~elementary-pantheon/switchboard/flowbox | ||||||||||||
Merge into: | lp://staging/~elementary-pantheon/switchboard/switchboard | ||||||||||||
Diff against target: |
847 lines (+290/-398) 6 files modified
schemas/org.pantheon.switchboard.gschema.xml (+2/-2) src/CMakeLists.txt (+2/-0) src/CategoryView.vala (+86/-380) src/Switchboard.vala (+10/-16) src/Widgets/CategoryFlowBox.vala (+139/-0) src/Widgets/CategoryIcon.vala (+51/-0) |
||||||||||||
To merge this branch: | bzr merge lp://staging/~elementary-pantheon/switchboard/flowbox | ||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Adam Bieńkowski (community) | testing | Approve | |
Review via email: mp+294295@code.staging.launchpad.net |
Commit message
CategoryView.vala:
* Rewrite the icon views as FlowBoxes
* Update copyright header
Switchboard.vala:
* Code Style
* Update calls to icon views to FlowBoxes
Schemas:
* Update default window size to fit default plug icons
Widgets:
* Add CategoryFlowBox and CategoryIcon widgets
Description of the change
I've been staring at this code long enough to probably not realize if I'm doing dumb things. I have noticed two regressions, but I'm not sure what's causing them:
* Pressing down from search entry skips personal category
* [GLib] g_sequence_get: assertion '!is_end (iter)' failed
To post a comment you must log in.
It works & looks great for me, besides those issues that are pointed out in the description.