Merge lp://staging/~elementary-pantheon/switchboard-plug-onlineaccounts/native-auth into lp://staging/~elementary-apps/switchboard-plug-onlineaccounts/trunk
Proposed by
Danielle Foré
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Merged at revision: | 313 | ||||||||
| Proposed branch: | lp://staging/~elementary-pantheon/switchboard-plug-onlineaccounts/native-auth | ||||||||
| Merge into: | lp://staging/~elementary-apps/switchboard-plug-onlineaccounts/trunk | ||||||||
| Diff against target: |
349 lines (+110/-51) 3 files modified
plugins/Providers/FastMail/fastmail.provider (+2/-0) src/Authentification/GraphicalDialog.vala (+105/-51) src/Authentification/Key.vala (+3/-0) |
||||||||
| To merge this branch: | bzr merge lp://staging/~elementary-pantheon/switchboard-plug-onlineaccounts/native-auth | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Adam Bieńkowski (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
fastmail.provider:
* Add DisplayName and SignUpURL
GraphicalDialog
* Remove remember checkbutton
* Redesign entries to be vertically linked entries with hint text
* Add SignUpUrl and DisplayName widgets
* Don't hardcode forgot password URL
* Activate save_button when password_entry is activated
Description of the change
This branch assumes that getting info from provider files is working (it isn't)
It adds a URL field in preparation for Nextcloud and generic cal/carddav, but the field is not connected to any logic.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The code looks okay to me, only a few minor code-style issues. Note that I didn't test it.