Merge lp://staging/~elementary-apps/switchboard/cleanup into lp://staging/~elementary-pantheon/switchboard/switchboard
Proposed by
Raphael Isemann
Status: | Rejected |
---|---|
Rejected by: | Julián Unrrein |
Proposed branch: | lp://staging/~elementary-apps/switchboard/cleanup |
Merge into: | lp://staging/~elementary-pantheon/switchboard/switchboard |
Diff against target: |
577 lines (+148/-120) 3 files modified
src/CategoryView.vala (+1/-1) src/EmbeddedAlert.vala (+1/-1) src/Switchboard.vala (+146/-118) |
To merge this branch: | bzr merge lp://staging/~elementary-apps/switchboard/cleanup |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Julián Unrrein (community) | Disapprove | ||
David Gomes (community) | Needs Fixing | ||
Review via email: mp+188034@code.staging.launchpad.net |
Description of the change
Fixing codestyle.
To post a comment you must log in.
Unmerged revisions
- 407. By David Gomes
-
Fixed yet more code style.
- 406. By David Gomes
-
More fixes.
- 405. By Raphael Isemann
-
cleaning CategoryView.vala
- 404. By Raphael Isemann
-
cleaning EmbeddedAlert.vala
- 403. By Raphael Isemann
-
cleaning Switchboard.vala
Code style
Diff lines 244-245, 262, 265, 310, 445: Put the blocks of code in separate lines from the "try" and "catch" statements:
try {
//...
} catch (Error e) {
//...
}
Diff line 303: A space after "else if" and before the parenthesis.
Diff line 320: A space on the other side of the parenthesis :)
Diff line 380: A space before the opening parenthesis.
Diff line 450: A space after the opening curly brace.