Merge lp://staging/~elementary-apps/switchboard/cleanup into lp://staging/~elementary-pantheon/switchboard/switchboard

Proposed by Raphael Isemann
Status: Rejected
Rejected by: Julián Unrrein
Proposed branch: lp://staging/~elementary-apps/switchboard/cleanup
Merge into: lp://staging/~elementary-pantheon/switchboard/switchboard
Diff against target: 577 lines (+148/-120)
3 files modified
src/CategoryView.vala (+1/-1)
src/EmbeddedAlert.vala (+1/-1)
src/Switchboard.vala (+146/-118)
To merge this branch: bzr merge lp://staging/~elementary-apps/switchboard/cleanup
Reviewer Review Type Date Requested Status
Julián Unrrein (community) Disapprove
David Gomes (community) Needs Fixing
Review via email: mp+188034@code.staging.launchpad.net

Description of the change

Fixing codestyle.

To post a comment you must log in.
Revision history for this message
Julián Unrrein (junrrein) wrote :

Code style

Diff lines 244-245, 262, 265, 310, 445: Put the blocks of code in separate lines from the "try" and "catch" statements:

try {
    //...
} catch (Error e) {
    //...
}

Diff line 303: A space after "else if" and before the parenthesis.

Diff line 320: A space on the other side of the parenthesis :)

Diff line 380: A space before the opening parenthesis.

Diff line 450: A space after the opening curly brace.

Revision history for this message
Julián Unrrein (junrrein) wrote :

I would offer to submit the changes myself (since I'm in ~elementary-apps too) but I am not able to compile this on Luna (GTK >= 3.6 required).

406. By David Gomes

More fixes.

Revision history for this message
David Gomes (davidgomes) wrote :

Junrrein, I fixed the stuff. Care to re-review?

review: Needs Fixing
Revision history for this message
Julián Unrrein (junrrein) wrote :

Re-indent diff lines 150, 153, 163-164, 391, they are part of foreach blocks.

You can close lines 163-164 in curly braces for clarity.

Diff line 225: Move the warning to its own line.

Diff line 373: Space after get_file_type.

Diff line 475: Space after search_box_activated.

I see you also fixed stuff I didn't catch, nice!

review: Needs Fixing
407. By David Gomes

Fixed yet more code style.

Revision history for this message
Julián Unrrein (junrrein) wrote :

It's ready to go.

Good work Raphael and Munchor!

review: Approve
Revision history for this message
Julián Unrrein (junrrein) wrote :

Rejecting this branch because there are major changes coming to Switchboard (see https://code.launchpad.net/~elementary-apps/switchboard/libpeas-isis/+merge/195417).

We should review that branch for code style later instead.

review: Disapprove

Unmerged revisions

407. By David Gomes

Fixed yet more code style.

406. By David Gomes

More fixes.

405. By Raphael Isemann

cleaning CategoryView.vala

404. By Raphael Isemann

cleaning EmbeddedAlert.vala

403. By Raphael Isemann

cleaning Switchboard.vala

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: