Screenshot

Merge lp://staging/~elementary-apps/screenshot-tool/check-for-scribbles into lp://staging/~elementary-apps/screenshot-tool/trunk

  1. check-for-scribbles
  2. Merge into trunk
Proposed by Danielle Foré
Status: Needs review
Proposed branch: lp://staging/~elementary-apps/screenshot-tool/check-for-scribbles
Merge into: lp://staging/~elementary-apps/screenshot-tool/trunk
Diff against target: 21 lines (+9/-3)
1 file modified
src/ScreenshotWindow.vala (+9/-3)
To merge this branch: bzr merge lp://staging/~elementary-apps/screenshot-tool/check-for-scribbles
Reviewer Review Type Date Requested Status
elementary Apps team Pending
Review via email: mp+316358@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Jung-Kyu Park (bagjunggyu) wrote :

It fixes the issue conceal feature which should be concealed and restored text.

Reply
Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

It would be better to stop the previous font ever being set to the scribble font, if possible - although this code should be kept as a backstop.

Reply
Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

A similar but slightly different solution is included in the branch lp:~jeremywootten/screenshot-tool/fix-1438250-include-child-windows. In my case the problem was caused by the program crashing during development but the linked bug here does not mention any crashes (although they could have been silent). My branch reduces the time the spent in the redacted state a little.

Reply

Unmerged revisions

281. By Danielle Foré

check that we're not setting back to the scribble font

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches