Merge lp://staging/~elementary-apps/maya/maya-saucy into lp://staging/~elementary-apps/maya/trunk

Great, tried it and it works. Only the radio buttons in the popover seem non-intuitive to me.

Maya crashes when I try adding an event to a Google calendar:

CalendarModel.vala:122: Cannot create calendar object: UNexpected HTTP status code 400 (Bad Request)
**
ERROR:/home/alexander/maya-saucy/build/src/Model/CalendarModel.c:426__lambda6_: assertion failes: (status==true)
Aborted (core dumped)

This should be a dependancy error,
do you have theese packages installed ?

liboauth0
evolution-data-server-common
libedataserver-1.2-17
libebackend-1.2-6
librest-0.7-0
libedata-cal-1.2-20
libgdata13
evolution-data-server-uoa

Yes, I have all of them installed

From the looks of the diff, there are random things I wanna fix here and there, but I'm on Windows without any text editor and no free time. If other devs (and Cody) want this merged right away, I'm okay with that, but if it's possible to wait until I'm back and you make the branch ~elementary-apps owned I'll be more than glad to do some fixing.

Also, adding ~elementary-design to the review because of the Google Accounts issue Daniel referred before (on BountySource I believe).

The app seems to run, but...

* adding a google calendar doesn't really make sense. I'm not sure what I'm doing. What is "user"? Is that my email address? Why wasn't I prompted for a password? "Create" doesn't really make sense as an action, I thought I was adding my account?
* What do the radio buttons do?
* I'm unable to delete the Google calendar that I added.
* There's an "edit" button but it doesn't do anything
* The default color for a calendar should probably never be black.

I noticed another bug:

When Maya starts up, the events of the selected day (the current date) are duplicated. Switching to another month and back fixes that.

Okay, a lot of changes now:

* Implemented the deletion according to the HIG conventions (providing an Undo button)
* Implemented the modification of calendars
* Removed the radio button (for the default calendar when creating an event) the user has to check the box when editing the calendar to make it default.
* Changed the color to Blue by default
* Added placeholder texts in every entry to show you example (you can enter your google user name if you have an @gmail.com or type the full address, it's detected afterward)
* Check for the calendar directly after the creation (and thus ask for a password if needed)
* Some ports to the new libecalendar and added required functions to the .vapi

I tried adding an event with "all day" enabled for Sep 23. Both time widgets were set to 9:00. After clicking "Create event", an event was created that covered the time span from the 22nd, 22:00 to the 23rd, 22:00.

In Google Calendar, it shows up as one event: Mo, 23. September, 00:00 – Di, 24. September, 00:00, and is being shown in the top line in the week overview, which shows events that last the whole day.

Google sync doens't seem to work for me. I've got a pretty "busy" schedule on Google Calendar, added my account but nothing seems to show up on Maya. (I prompted my username and then it asked for password).

Revert translation changes. The .pot file should be updated after this is merged into trunk and we do not support bypassing the launchpad translations interface.

bzr revert -r 479 po/fr.po po/maya.pot
bzr commit -m "Reverted translations"

I reverted the translations amongst other cleanup.

Is it ready to merge into trunk ?

How often do the events get refreshed to show new events received from the server?

I don't know, everything is done by the evolution server.

Does David Gomes have anything else to say before merge?

On Sun, Nov 17, 2013 at 5:32 AM, Corentin Noël <email address hidden> wrote:

> I don't know, everything is done by the evolution server.
> --
> https://code.launchpad.net/~elementary-apps/maya/maya-saucy/+merge/182224
> You are reviewing the proposed merge of lp:maya/isis into lp:maya.
>

--
Cody Garver