Captive Portal Assistant

Merge lp://staging/~elementary-apps/capnet-assist/prettify-ssl-popover into lp://staging/~elementary-apps/capnet-assist/trunk

  1. prettify-ssl-popover
  2. Merge into trunk
Proposed by Danielle Foré
Status: Merged
Approved by: Danielle Foré
Approved revision: 33
Merged at revision: 32
Proposed branch: lp://staging/~elementary-apps/capnet-assist/prettify-ssl-popover
Merge into: lp://staging/~elementary-apps/capnet-assist/trunk
Diff against target: 69 lines (+25/-10)
1 file modified
src/CaptiveLogin.vala (+25/-10)
To merge this branch: bzr merge lp://staging/~elementary-apps/capnet-assist/prettify-ssl-popover
Reviewer Review Type Date Requested Status
The Lemon Man (community) code Approve
Review via email: mp+276063@code.staging.launchpad.net

Commit message

* Switch nested boxes to gtk.grid
* Show web view uri
* Align according to HIG

To post a comment you must log in.
lp://staging/~elementary-apps/capnet-assist/prettify-ssl-popover updated
33. By Danielle Foré

re-add class to secondary text

Revision history for this message
The Lemon Man (lemonboy) wrote :

LGTM. Dan mentioned the icon tinting works with a recent eGTK commit so it's fine.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: