Merge lp://staging/~elachuni/rnr-server/amqp-oopses into lp://staging/rnr-server

Proposed by Anthony Lenton
Status: Rejected
Rejected by: Natalia Bidart
Proposed branch: lp://staging/~elachuni/rnr-server/amqp-oopses
Merge into: lp://staging/rnr-server
Diff against target: 462 lines (+189/-71)
12 files modified
.bzrignore (+1/-0)
django_project/config_dev/config/main.cfg (+6/-2)
django_project/config_dev/settings.py (+0/-3)
requirements.txt (+4/-2)
src/reviewsapp/management/commands/runserver.py (+36/-0)
src/reviewsapp/schema.py (+17/-0)
src/reviewsapp/templates/500.html (+1/-3)
src/reviewsapp/tests/test_views.py (+1/-1)
src/reviewsapp/tests/test_wsgi.py (+19/-32)
src/reviewsapp/urls.py (+1/-1)
src/reviewsapp/views/moderation.py (+34/-11)
src/reviewsapp/wsgi.py (+69/-16)
To merge this branch: bzr merge lp://staging/~elachuni/rnr-server/amqp-oopses
Reviewer Review Type Date Requested Status
Michael Nelson (community) Approve
Review via email: mp+151302@code.staging.launchpad.net

Description of the change

This branch switches to configglue 0.0.5 for setting amqp oops publishing.

There is also a custom wsgi handler now that will generate an oops id for every exception, and display the oops id on the error page correctly.

Finally, a custom runserver command is provided to run the custom wsgi stack in dev, to generate oopses in dev.

To post a comment you must log in.
234. By Anthony Lenton

Removed storm from requirements

Revision history for this message
Anthony Lenton (elachuni) wrote :

Also, storm is no longer required since we moved from wsgi_oops to oops_wsgi...

Revision history for this message
Michael Nelson (michael.nelson) wrote :

If we update to Django 1.4, the custom runserver command isn't needed:

https://docs.djangoproject.com/en/1.4/ref/settings/#std:setting-WSGI_APPLICATION

review: Approve
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Setting MP as Rejected to reduce numbers of landing candidates in @reviewlist. Change status again if this MP is still current.

Unmerged revisions

234. By Anthony Lenton

Removed storm from requirements

233. By Anthony Lenton

Plugged in oops_dictconfig 0.0.5.
Display an oops id on every error page.
Enable oops tracking in dev.
Don't track oopses for 404 responses.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches