Merge lp://staging/~elachuni/piston-mini-client/error-codes into lp://staging/piston-mini-client
Proposed by
Anthony Lenton
| Status: | Merged |
|---|---|
| Merged at revision: | 49 |
| Proposed branch: | lp://staging/~elachuni/piston-mini-client/error-codes |
| Merge into: | lp://staging/piston-mini-client |
| Diff against target: |
97 lines (+23/-5) 2 files modified
piston_mini_client/failhandlers.py (+19/-5) piston_mini_client/tests/test_failhandlers.py (+4/-0) |
| To merge this branch: | bzr merge lp://staging/~elachuni/piston-mini-client/error-codes |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Danny Tamez (community) | Approve | ||
| software-store-developers | Pending | ||
|
Review via email:
|
|||
Description of the change
As the related bug #932715 points out, the code for deciding which status codes were errors was kind of sucky: it had a (short) list of status codes considered errors.
Instead, this branch considers everything at or above 400 an error, and anything below that a success.
While I was there, I added a couple of status-
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks fine and tests all pass.