Merge lp://staging/~elachuni/charmsupport/nrpe-tests into lp://staging/charmsupport
Proposed by
Anthony Lenton
| Status: | Merged |
|---|---|
| Merged at revision: | 35 |
| Proposed branch: | lp://staging/~elachuni/charmsupport/nrpe-tests |
| Merge into: | lp://staging/charmsupport |
| Prerequisite: | lp://staging/~elachuni/charmsupport/log-tweak |
| Diff against target: |
259 lines (+222/-7) 2 files modified
charmsupport/nrpe.py (+9/-7) tests/test_nrpe.py (+213/-0) |
| To merge this branch: | bzr merge lp://staging/~elachuni/charmsupport/nrpe-tests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| CharmSupport Developers | Pending | ||
|
Review via email:
|
|||
Description of the change
This branch adds tests for the nrpe module.
While writing tests I found an issue with the shortname regex, that would approve *any* shortname, so that's fixed.
Plus one minor improvement to _locate_cmd, so that argument-less commands aren't run with a trailing whitespace.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
