Launchpad itself

Merge lp://staging/~edwin-grubbs/launchpad/featured-projects-ui-3 into lp://staging/launchpad

  1. featured-projects-ui-3
  2. Merge into devel
Proposed by Edwin Grubbs
Status: Merged
Approved by: Barry Warsaw
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp://staging/~edwin-grubbs/launchpad/featured-projects-ui-3
Merge into: lp://staging/launchpad
Diff against target: None lines
To merge this branch: bzr merge lp://staging/~edwin-grubbs/launchpad/featured-projects-ui-3
Reviewer Review Type Date Requested Status
Barry Warsaw (community) code ui* Approve
Review via email: mp+12053@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Summary
-------

Convert root-featuredprojects.pt to UI 3.0.

Tests
-----

./bin/test -vv -t featuredproject.txt

Demo and Q/A
------------

* Open http://launchpad.dev/+featuredprojects

Revision history for this message
Barry Warsaw (barry) wrote :

Hi Edwin, thanks for working on this.

I'd prefer it if you wrote the code like this:

    label = 'foo'
    page_title = label

because eventually you will be able to get rid of the page_title line.

review: Approve (code ui*)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/pagetitles.py'
2--- lib/canonical/launchpad/pagetitles.py 2009-09-17 16:12:20 +0000
3+++ lib/canonical/launchpad/pagetitles.py 2009-09-18 13:24:10 +0000
4@@ -786,8 +786,6 @@
5
6 remotebug_index = ContextTitle('%s')
7
8-root_featuredprojects = 'Manage featured projects in Launchpad'
9-
10 root_index = 'Launchpad'
11
12 rosetta_about = 'About Launchpad Translations'
13
14=== modified file 'lib/canonical/launchpad/templates/root-featuredprojects.pt'
15--- lib/canonical/launchpad/templates/root-featuredprojects.pt 2009-07-17 17:59:07 +0000
16+++ lib/canonical/launchpad/templates/root-featuredprojects.pt 2009-09-18 13:24:10 +0000
17@@ -3,17 +3,12 @@
18 xmlns:tal="http://xml.zope.org/namespaces/tal"
19 xmlns:metal="http://xml.zope.org/namespaces/metal"
20 xmlns:i18n="http://xml.zope.org/namespaces/i18n"
21- xml:lang="en"
22- lang="en"
23- dir="ltr"
24- metal:use-macro="view/macro:page/applicationhome"
25+ metal:use-macro="view/macro:page/main_only"
26 i18n:domain="launchpad"
27 >
28
29 <body>
30
31-<h1 metal:fill-slot="heading">Manage featured projects</h1>
32-
33 <div metal:fill-slot="main">
34
35 <div metal:use-macro="context/@@launchpad_form/form">
36
37=== modified file 'lib/lp/registry/browser/featuredproject.py'
38--- lib/lp/registry/browser/featuredproject.py 2009-06-25 04:06:00 +0000
39+++ lib/lp/registry/browser/featuredproject.py 2009-09-18 13:24:10 +0000
40@@ -41,6 +41,8 @@
41 class FeaturedProjectsView(LaunchpadFormView):
42 """A view for adding and removing featured projects."""
43
44+ page_title = label = 'Manage featured projects in Launchpad'
45+
46 schema = FeaturedProjectForm
47 custom_widget('remove', LabeledMultiCheckBoxWidget)
48