Launchpad itself

Merge lp://staging/~edwin-grubbs/launchpad/bug-577492-packaging-duplicates into lp://staging/launchpad

bug-577492-packaging-duplicates
Merge into devel

Proposed by Edwin Grubbs on 2010-07-29

Status:

Merged

Approved by:

Edwin Grubbs on 2010-07-30

Approved revision:

no longer in the source branch.

Merged at revision:

11266

Proposed branch:

lp://staging/~edwin-grubbs/launchpad/bug-577492-packaging-duplicates

Merge into:

lp://staging/launchpad

Diff against target:

80 lines (+29/-14)

2 files modified

lib/lp/registry/model/distroseries.py (+21/-13)
lib/lp/registry/tests/test_distroseries.py (+8/-1)

To merge this branch:

bzr merge lp://staging/~edwin-grubbs/launchpad/bug-577492-packaging-duplicates

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Brad Crittenden (community)	code	2010-07-29	Approve on 2010-07-29
Review via email: mp+31297@code.staging.launchpad.net

Description of the change

Summary
-------

Eliminate duplicates on $distroseries/+packaging page.

Tests
-----

./bin/test -vv -m 'test_distroseries$'
./bin/test -vvt 'xx-show-distroseries-packaging.txt|doc/distroseries.txt'

Demo and Q/A
------------

* Open https://edge.launchpad.net/debian/squeeze/+packaging
* Each sourcepackagename should only appear once in the list.

Revision history for this message

Brad Crittenden (bac) wrote on 2010-07-29:

Looks good. Q: should you be using the slave store instead of IStore(self)?

review: Approve (code)

Revision history for this message

Edwin Grubbs (edwin-grubbs) wrote on 2010-07-29:

> Looks good. Q: should you be using the slave store instead of IStore(self)?

IStore() uses the default store, so it will use the slave store
automatically unless the user has made writes on launchpad recently,
in which case, using the master store is necessary to ensure that it
doesn't appear that the user's changes got reverted.