Merge lp://staging/~edwin-grubbs/launchpad/bug-577492-needspackaging-duplicates into lp://staging/launchpad
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Approved by: | Jelmer Vernooij | ||||||||
| Approved revision: | no longer in the source branch. | ||||||||
| Merged at revision: | 11248 | ||||||||
| Proposed branch: | lp://staging/~edwin-grubbs/launchpad/bug-577492-needspackaging-duplicates | ||||||||
| Merge into: | lp://staging/launchpad | ||||||||
| Diff against target: |
1009 lines (+386/-327) 8 files modified
lib/lp/registry/browser/distroseries.py (+3/-6) lib/lp/registry/browser/tests/test_distroseries_views.py (+52/-0) lib/lp/registry/doc/distroseries.txt (+286/-284) lib/lp/registry/interfaces/distroseries.py (+5/-4) lib/lp/registry/model/distroseries.py (+25/-23) lib/lp/registry/stories/distroseries/xx-distroseries-index.txt (+6/-1) lib/lp/registry/templates/distroseries-portlet-packaging.pt (+1/-1) lib/lp/registry/tests/test_distroseries.py (+8/-8) |
||||||||
| To merge this branch: | bzr merge lp://staging/~edwin-grubbs/launchpad/bug-577492-needspackaging-duplicates | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jelmer Vernooij (community) | code | Approve | |
|
Review via email:
|
|||
Description of the change
Summary
-------
Sped up +needs-packaging page and the needs-packaging portlet on the
distroseries +index page by making getPrioritizedU
return a result set, so that batching will result in a limited query.
Previously, the result set was turned into a list in order to format
each item as a dictionary. Therefore, it would load 13,000 source
packages, and then iterate just over the first batch.
I also fixed the name of getPrioritizedP
return a result set instead of a list.
Tests
-----
./bin/test -vv -t 'test_distroser
Demo and Q/A
------------
* Open https:/
* It should not timeout.
* Open https:/
* The "Upstream packaging" portlet should say
"Needs more information or linking to upstream" and list some source
packages.
Lint
----
There are over 700 lint errors due to bad indentation in doctests, so I
will add those changes later, so that reviewers aren't scared away.
Nice, I'm looking forward to seeing this land!
One minor comment: lib/lp/