Launchpad itself

Merge lp://staging/~edwin-grubbs/launchpad/bug-526608-milestone-ajax-plus-icon into lp://staging/launchpad

bug-526608-milestone-ajax-plus-icon
Merge into devel

Proposed by Edwin Grubbs on 2010-12-21

Status:

Merged

Approved by:

Edwin Grubbs on 2010-12-21

Approved revision:

no longer in the source branch.

Merged at revision:

12137

Proposed branch:

lp://staging/~edwin-grubbs/launchpad/bug-526608-milestone-ajax-plus-icon

Merge into:

lp://staging/launchpad

Diff against target:

78 lines (+28/-30)

2 files modified

lib/lp/bugs/browser/bugtask.py (+14/-0)
lib/lp/bugs/templates/bugtask-tasks-and-nominations-table-row.pt (+14/-30)

To merge this branch:

bzr merge lp://staging/~edwin-grubbs/launchpad/bug-526608-milestone-ajax-plus-icon

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Curtis Hovey (community)	code	2010-12-21	Approve on 2010-12-21
j.c.sackett (community)	code*	2010-12-21	Approve on 2010-12-21
Review via email: mp+44382@code.staging.launchpad.net

Commit message

[r=jcsackett,sinzui][ui=none][bug=526608] Ajaxify plus sign next to ajaxified link for targeting a bugtask to a milestone.

Description of the change

Summary
-------

When a bugtask has a "Target to Milestone" ajax link, the (+) icon
should also be ajaxified instead of taking you to a new page.

Tests
-----

./bin/test -vv --layer=BugsWindmillLayer

Demo and Q/A
------------

* Open https://bugs.launchpad.dev/firefox/+bug/1
    * Target each bugtask to a milestone using the (+) icon.
    * Remove the milestone from each bugtask.
    * Target each bugtask to a milestone again to ensure that the
      javascript shows and hides all the elements properly.

Revision history for this message

j.c.sackett (jcsackett) wrote on 2010-12-21:

Looks good to me, assuming the text show/hide tool is tested already and therefor not showing in the diff. My memory tells me it is.

I'm getting Curtis to follow up; if it needs it, I imagine he can provide a UI review as well.

review: Approve (code*)

Revision history for this message

Curtis Hovey (sinzui) wrote on 2010-12-21:

The content of the anchors should abut the tags to prevent odd underlining: <a ..><img ../></a>

review: Approve (code)

Revision history for this message

Edwin Grubbs (edwin-grubbs) wrote on 2010-12-21:

> The content of the anchors should abut the tags to prevent odd underlining: <a
> ..><img ../></a>

I ended up changing the addicon into a sprite, since Firefox would apply underlining to the icon since it was in the link with "Target to milestone". I didn't change the editicon into a sprite, since the browsers would hide the <a> unless there was a   in it, but then that would be underlined weirdly.