Merge lp://staging/~edwin-grubbs/launchpad/bug-248518-setPreferredEmail into lp://staging/launchpad
Proposed by
Edwin Grubbs
| Status: | Merged |
|---|---|
| Approved by: | Curtis Hovey |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~edwin-grubbs/launchpad/bug-248518-setPreferredEmail |
| Merge into: | lp://staging/launchpad |
| Prerequisite: | lp://staging/~edwin-grubbs/launchpad/bug-553384-deactivated-project-oops |
| Diff against target: |
120 lines (+23/-20) 5 files modified
lib/lp/bugs/browser/bugalsoaffects.py (+1/-1) lib/lp/bugs/browser/tests/bugtask-adding-views.txt (+0/-1) lib/lp/registry/doc/person.txt (+13/-5) lib/lp/registry/model/person.py (+0/-11) lib/lp/testing/factory.py (+9/-2) |
| To merge this branch: | bzr merge lp://staging/~edwin-grubbs/launchpad/bug-248518-setPreferredEmail |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Curtis Hovey (community) | code | Approve | |
|
Review via email:
|
|||
Description of the change
Summary
-------
Person.
Implementation details
-------
Changed setPreferredEmail and fixed tests.
lib/
lib/
lib/
Fixed lint errors.
lib/
lib/
Tests
-----
./bin/test -vv -t 'doc/person.
Demo and Q/A
------------
This has no effect on the UI.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I am surprised there is not comparable test for account.activate() in doc/account. I think your test is the only documentation we have. My initial though was to move your test, but I think your decision was right. I think your tests tells other launchpad developer how to get a person's account activated.
I like your graceful solution in the factory.