Merge lp://staging/~echaskes/unity-control-center/fix-user-password-dialog into lp://staging/unity-control-center
Status: | Merged |
---|---|
Approved by: | Sebastien Bacher |
Approved revision: | 12777 |
Merged at revision: | 12780 |
Proposed branch: | lp://staging/~echaskes/unity-control-center/fix-user-password-dialog |
Merge into: | lp://staging/unity-control-center |
Diff against target: |
14 lines (+4/-0) 1 file modified
panels/user-accounts/um-password-dialog.c (+4/-0) |
To merge this branch: | bzr merge lp://staging/~echaskes/unity-control-center/fix-user-password-dialog |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sebastien Bacher | Approve | ||
Review via email: mp+217167@code.staging.launchpad.net |
Commit message
Updated um-password-
Description of the change
There is currently a bug in the User Accounts password dialog box: if a user has been set to "Log in without a password" and is subsequently set to "Disable this account", the user is not removed from the nopasswordlogin group. The result is that the user can still log in without a password, even though an admin has locked the account. This is a security issue.
This is easily tested by following the above steps and confirming the users group memberships.
The bug stems from lack of a single line of code in um-password-
Current code (starting line 268) locks user, removes automatic login, but does not change password mode:
Proposed code also changes the password mode:
This is easy to test by compiling/
thanks, that looks fine to me!