Merge lp://staging/~dreis-pt/project-service/7.0-project_categ-dr into lp://staging/~project-core-editors/project-service/trunk

Hi, Daniel,

Why is the module 'crm_categ_hierarchy' removed?

Regards.

That a good question Pedro:
In v7 Project Categories is a new model, so it's no longer based on CRM Categories.
So, keeping the "crm" indication in the module would give a wrong indication:
the corresponding v7 functionality no longer touches on CRM models.

Don't you think then that it's better to use 'bzr mv' command instead of renaming folder outside the source control to keep changes and see a proper diff?

Regards.

Well, you're right, it could, but it wasn't the workflow I used:
I didn't actually port the v6 module: I wrote a new one from scratch, with a slightly different purpose in mind - "Per Project Configurable Categories" instead of just a "Category hierarchical structure".

Do you think recreating the branch that way would bring significant benefits to the code review?

Well, it depends on the changes you have made, but seeing the piece of code, I think it can be handled, so I'll made the review directly.

Regards.

OK, watching the code, I don't see any big, problem, so I give a code review approval.

Regards.

LGTM

Hi Daniel

I think the check recursion have been lost during the conversion

    _constraints = [
        (osv.osv._check_recursion, 'Error! Cannot create recursive cycle.', ['parent_id'])
    ]

Thanks for your contribution

Fixed.

Thanks for the fix Daniel, this is all clean now, I assume it's still ok with the 2 previous approval and I merge that.