Project for Service Management

Merge lp://staging/~dreis-pt/project-service/7.0-issue_task-dr into lp://staging/~project-core-editors/project-service/trunk

  1. 7.0-issue_task-dr
  2. Merge into trunk
Proposed by Daniel Reis
Status: Merged
Merged at revision: 38
Proposed branch: lp://staging/~dreis-pt/project-service/7.0-issue_task-dr
Merge into: lp://staging/~project-core-editors/project-service/trunk
Diff against target: 1627 lines (+467/-922)
21 files modified
project_issue_service/board_project_view.xml (+0/-12)
project_issue_service/project_issue_workflow.xml (+0/-108)
project_issue_service/wizard/__init__.py (+0/-1)
project_issue_service/wizard/project_task_reevaluate.py (+0/-38)
project_issue_task/__init__.py (+3/-4)
project_issue_task/__openerp__.py (+20/-27)
project_issue_task/i18n/fr.po (+97/-0)
project_issue_task/i18n/project_issue_task.pot (+97/-0)
project_issue_task/i18n/pt.po (+97/-0)
project_issue_task/project_issue.py (+40/-142)
project_issue_task/project_issue_view.xml (+9/-163)
project_issue_task/project_task.py (+34/-71)
project_issue_task/project_task_cause.py (+6/-10)
project_issue_task/project_task_cause_view.xml (+19/-10)
project_issue_task/project_task_view.xml (+14/-39)
project_issue_task/security/ir.model.access.csv (+1/-1)
project_issue_task/security/project_security.xml (+30/-0)
project_task_service/__init__.py (+0/-4)
project_task_service/__openerp__.py (+0/-52)
project_task_service/project_task.py (+0/-88)
project_task_service/project_task_view.xml (+0/-152)
To merge this branch: bzr merge lp://staging/~dreis-pt/project-service/7.0-issue_task-dr
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp code review Approve
Joël Grand-Guillaume @ camptocamp code review, no tests Approve
Yannick Vaucher @ Camptocamp code review, no tests Approve
Review via email: mp+195985@code.staging.launchpad.net

Description of the change

Module to "Use Tasks to support Issue resolution reports".
Simplifies and replaces the former v6 "project_issue_service" and "project_task_service".

To post a comment you must log in.
lp://staging/~dreis-pt/project-service/7.0-issue_task-dr updated
30. By Daniel Reis

Add french translation, credits to invitu

31. By Daniel Reis

Fixed to make the related issue a stored function field

Revision history for this message
invitu (invitu) wrote :

Dear Daniel

We think that task priority should be synchronized with issue priority

In the other way, changes in task stage should synchronize with issue stage

Please check out our MP

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi,

Thanks for the contribs ! I saw few little stuff here :

 * Use from . import XYZ
 * Use 'data' and 'demo' in __openerp__.py, update_xml, init_xml, etc.. are deprecated
 * Line 1018 : you miss a context propagation

Otherwise all good.

Regards,

Joël

review: Needs Fixing (code review, no tests)
lp://staging/~dreis-pt/project-service/7.0-issue_task-dr updated
32. By Daniel Reis

Fixes from code review

33. By Daniel Reis

Fix trailing empty line

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Hello Daniel,

ll.737-738 dict comprehension is not python 2.6 compatible please use dict constructor instead.

Thanks

review: Needs Fixing (code review, no tests)
Revision history for this message
Daniel Reis (dreis-pt) wrote :

Should I be required to support Python < 2.7 ?

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

As openerp is 2.6 compatible inserting 2.7 code would break the compatibility.

https://doc.openerp.com/v7.0/install/linux/server/
"Python 2.6 or later is required for OpenERP 6.1."

No further update for 7.0 was made so we should stick to 2.6 compatibility as in 6.1.

Revision history for this message
Daniel Reis (dreis-pt) wrote :

Yannick, that doc page states that "Python 2.6 or later is required for OpenERP 6.1".
Well, 6.1 is not officially supported by now, and I believe that neither Python 2.6.
I would like some more opinions on this. Do you think we should start a thread on the ML?

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

This can only be a good idea to launch a talk on ML. At least it can sync everyone on that subject.

lp://staging/~dreis-pt/project-service/7.0-issue_task-dr updated
34. By Daniel Reis

Changed dict comprehension into dict constructor, for python 2.6 compatibility

Revision history for this message
Daniel Reis (dreis-pt) wrote :

Yannick, I made the fix you suggested.

Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Thanks for the fix and having launched the talk that was quite uncertain for everyone.

LGTM

review: Approve (code review, no tests)
Revision history for this message
Daniel Reis (dreis-pt) wrote :

OK, just need Joël's review now.

Revision history for this message
Daniel Reis (dreis-pt) wrote :

@Joel: I believe issues from your review have been addressed in rev 32.
Thanks!

Revision history for this message
Daniel Reis (dreis-pt) wrote :

This is the oldest MP on this project, and I believe that all issues have been fixed.
Unless opinions otherwise, I will go on with it's merge.

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

LGTM, Sorry for late reply, was on holidays

review: Approve (code review, no tests)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Hi Daniel,

I tried to merge your branch and unfortunately got a conflict.
Can you rebase from the head?

review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches