Department Management

Merge lp://staging/~dreis-pt/department-mgmt/project-v7b into lp://staging/~department-core-editors/department-mgmt/7.0

project-v7b
Merge into 7.0

Proposed by Daniel Reis on 2013-03-04

Status:	Merged
Merged at revision:	11
Proposed branch:	lp://staging/~dreis-pt/department-mgmt/project-v7b
Merge into:	lp://staging/~department-core-editors/department-mgmt/7.0
Prerequisite:	lp://staging/~dreis-pt/department-mgmt/analytic-v7
Diff against target:	375 lines (+156/-170) 8 files modified hr_timesheet_department/LICENSE (+18/-0) hr_timesheet_department/__init__.py (+1/-0) hr_timesheet_department/__openerp__.py (+16/-0) hr_timesheet_department/hr_timesheet_view.xml (+46/-0) project_department/LICENSE (+18/-0) project_department/__init__.py (+1/-32) project_department/__openerp__.py (+10/-51) project_department/project_view.xml (+46/-87)
To merge this branch:	bzr merge lp://staging/~dreis-pt/department-mgmt/project-v7b
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Guewen Baconnier @ Camptocamp		2013-03-04	Pending
Review via email: mp+151562@code.staging.launchpad.net

This proposal supersedes a proposal from 2013-02-28.

Description of the change

[Resubmitting with fixes and proper prerequisite branch info]:
Migrating "project_department" to v7.
Timesheet features were split into a separate module.
Both these modules will auto-install if "analytic_department" is also installed.

Revision history for this message

Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote on 2013-03-04: Posted in a previous version of this proposal

Nitpicking:

l.299,314,326,338,350,429,441,453,702,714,729
The <field name="type">...</field> is now useless in v7, they can be removed.

Otherwise, it seems good to me, so I approve.

review: Approve (code review, no test)

Revision history for this message

Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote on 2013-03-04: Posted in a previous version of this proposal

hmm, not noticed that before, can you remove the +x flag on some .py files ?

=== modified file 'analytic_department/__init__.py' (properties changed: -x to +x)
=== modified file 'analytic_department/__openerp__.py' (properties changed: -x to +x)
=== modified file 'analytic_department/analytic.py' (properties changed: -x to +x)

review: Needs Fixing

Revision history for this message

Daniel Reis (dreis-pt) wrote on 2013-03-04:

Prerequisite added and MP resubmited.

Revision history for this message

Nhomar - Vauxoo (nhomar) wrote on 2013-03-18:

Daniel.

When it is useful?, why do you need department in timesheet friend?

Thanks in advance.

Regards

Revision history for this message

Daniel Reis (dreis-pt) wrote on 2013-03-18:

@nhomar: actually I don't, but Camp2Camp does (or at least it's in their codebase).
That's I'm separating it into a different module. I do need Departments in Projects and in Issues (MP on the way).

Revision history for this message

Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote on 2013-03-19:

@ Nohmar, this is useful to sum spent hours by department for a same project, in our case for revenue splitting for example. But could just be to have a reporting on average repatition between department per project or such a thing we do need at least...

Hope this helps,

Joël

Le 18 mars 2013 à 15:04, Nhomar - Vauxoo <email address hidden> a écrit :

> Daniel.
>
> When it is useful?, why do you need department in timesheet friend?
>
> Thanks in advance.
>
> Regards
> --
> https://code.launchpad.net/~dreis-pt/department-mgmt/project-v7b/+merge/151562
> Your team Department Core Editors is subscribed to branch lp:department-mgmt.