Merge lp://staging/~dreis-pt/department-mgmt/project-issue into lp://staging/~department-core-editors/department-mgmt/7.0

Proposed by Daniel Reis
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 17
Merged at revision: 17
Proposed branch: lp://staging/~dreis-pt/department-mgmt/project-issue
Merge into: lp://staging/~department-core-editors/department-mgmt/7.0
Diff against target: 193 lines (+161/-0)
6 files modified
project_issue_department/__init__.py (+3/-0)
project_issue_department/__openerp__.py (+44/-0)
project_issue_department/i18n/project_issue_department.pot (+16/-0)
project_issue_department/project_issue.py (+47/-0)
project_issue_department/project_issue_view.xml (+48/-0)
project_issue_department/security/ir.model.access.csv (+3/-0)
To merge this branch: bzr merge lp://staging/~dreis-pt/department-mgmt/project-issue
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no tests Approve
Omar (Pexego) code review, no test Approve
Maxime Chambreuil (http://www.savoirfairelinux.com) code review Needs Fixing
Guewen Baconnier @ Camptocamp Needs Fixing
Joël Grand-Guillaume @ camptocamp code review, no tests Approve
Review via email: mp+175079@code.staging.launchpad.net

Description of the change

New module to add Department to Project Issues.

To post a comment you must log in.
Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Thanks !

LGTM

review: Approve (code review, no tests)
Revision history for this message
Daniel Reis (dreis-pt) wrote :

Did some fixes. Ready for review now.

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Thanks

l.84 can you use the complete namespace i.e. from openerp.osv import fields, orm ?

review: Needs Fixing
14. By Daniel Reis

Fix complete namespace for openerp.osv

15. By Daniel Reis

Fix whitespace

Revision history for this message
Daniel Reis (dreis-pt) wrote :

Fixed.

Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) wrote :

Hello Daniel,

Please add the translation file to this module.

Thanks!

review: Needs Fixing (code review)
16. By Daniel Reis

Add .pot file

17. By Daniel Reis

Fix child_of operator on Department's filter made it not work at all

Revision history for this message
Daniel Reis (dreis-pt) wrote :

Done!

Revision history for this message
Omar (Pexego) (omar7r) wrote :

LGTM

review: Approve (code review, no test)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

LGTM

review: Approve (code review, no tests)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches