Merge lp://staging/~dpniel/ubuntu-autopilot-tests/test-runner into lp://staging/ubuntu-autopilot-tests

Proposed by Dan Chapman 
Status: Merged
Approved by: Dan Chapman 
Approved revision: 70
Merged at revision: 64
Proposed branch: lp://staging/~dpniel/ubuntu-autopilot-tests/test-runner
Merge into: lp://staging/ubuntu-autopilot-tests
Diff against target: 1054 lines (+995/-0)
9 files modified
README.md (+113/-0)
desktop-autopilot-runner/config/testrunner.cfg (+35/-0)
desktop-autopilot-runner/custom-installation/hooks/casper-bottom.sh (+30/-0)
desktop-autopilot-runner/custom-installation/iso-override/etc/rsyslog.d/50-default.conf (+69/-0)
desktop-autopilot-runner/custom-installation/iso-override/etc/xdg/autostart/autopilot.desktop (+9/-0)
desktop-autopilot-runner/custom-installation/iso-override/etc/xdg/lxsession/Lubuntu/autostart (+1/-0)
desktop-autopilot-runner/custom-installation/iso-override/usr/local/bin/run-autopilot.sh (+332/-0)
desktop-autopilot-runner/run-autopilot-test (+392/-0)
desktop-autopilot-runner/splitlogs.awk (+14/-0)
To merge this branch: bzr merge lp://staging/~dpniel/ubuntu-autopilot-tests/test-runner
Reviewer Review Type Date Requested Status
Nicholas Skaggs (community) Approve
Review via email: mp+206581@code.staging.launchpad.net

Description of the change

This MP adds a test runner to run the autopilot tests in a pristine environment. See the enclosed README for info on usage.

It work pretty much the same as the ubiquity runner and is just a modified copy of that runner

To post a comment you must log in.
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

With this runner, we should be able to provide an easier workflow for running these tests in a similar environment as jenkins. This should help in reproducing issues. I suppose this could also be helpful in verifying tests work when run in a pristine environment; probably useful to verify before final merge.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

I'm curious about desktop-autopilot-runner/custom-installation/iso-override/etc/apt/sources.list

deb http://archive.ubuntu.com/ubuntu/ trusty main restricted universe multiverse

We're pushing trusty in there; is there a more generic way to specify what we want? Going forward trusty isn't going to be it, and I don't want to push updates for something so trivial.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Looks good. I know jibel likes to push things into /tmp, so I suppose I'm ok with using /tmp to store the results. I personally don't like putting longterm things in there.

Overall, I approve, just have the one question above.

review: Needs Information
Revision history for this message
Dan Chapman  (dpniel) wrote :

It's easy enough to either re-write/update the sources.list file. I'll get that updated.

Where would you rather the artefacts ended up? as I want it to be more of a general purpose tool for running any autopilot test than the ubiquity runner currently is.

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

I would rather the results ended up in /home.. /home/autopilot-testrunner?

Revision history for this message
Dan Chapman  (dpniel) wrote :

Sounds good to me. I'll change that

Revision history for this message
Adam Smith (adam-disc0tech) wrote :

It would be great to be able run files from a local path instead of LP.

67. By Dan Chapman 

Removed apt/sources.list and just add-apt-repo universe & multiverse instead

Artifacts are now stored in $HOME/ubuntu_autopilot.tests instead of /tmp

Updated README

Revision history for this message
Dan Chapman  (dpniel) wrote :

Ok so changes made.

1) Removed the hardcoded sources.list and now just enable repositories using add-apt-repository
2) Artefacts now stored in $HOME/ubuntu_autopilot.tests rather than temp directory
3) Updated README

@Adam From an MP review / Jenkins point of view pulling from bzr branches is ideal, so I don't want to make any changes in this branch. But i agree the ability to use local directories for developing tests would be a nice feature. Once this is merged if you could file a bug for a new feature that would be great :-)

68. By Dan Chapman 

added retrieval of upstart logs for test artefacts

69. By Dan Chapman 

added partner repository

70. By Dan Chapman 

remove partner repo as it's archive.canonical.com and not archive.ubuntu.com

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Here and I thought this was waiting on you. Approved on my end ;-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches