Ubuntu Autopilot Tests

Merge lp://staging/~dpniel/ubuntu-autopilot-tests/add_pyflakes_pep8 into lp://staging/ubuntu-autopilot-tests

  1. add_pyflakes_pep8
  2. Merge into trunk
Proposed by Dan Chapman 
Status: Merged
Approved by: Dan Chapman 
Approved revision: 65
Merged at revision: 65
Proposed branch: lp://staging/~dpniel/ubuntu-autopilot-tests/add_pyflakes_pep8
Merge into: lp://staging/ubuntu-autopilot-tests
Diff against target: 114 lines (+94/-1)
3 files modified
checkformat/run-pep8 (+6/-0)
checkformat/run-pyflakes (+74/-0)
debian/rules (+14/-1)
To merge this branch: bzr merge lp://staging/~dpniel/ubuntu-autopilot-tests/add_pyflakes_pep8
Reviewer Review Type Date Requested Status
Nicholas Skaggs (community) Approve
Review via email: mp+206927@code.staging.launchpad.net

Description of the change

Adds pyflakes and pep8 checks to debian rules for use before mergeing. Lets get some standards involved :-D

To post a comment you must log in.
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

So this is intended to be manually run as part of reviews; and folks submitting merges can run beforehand to check for themselves?

Revision history for this message
Dan Chapman  (dpniel) wrote :

Yes indeed, i noticed jackson did all the pep-8 errors a while back but pyflakes were left untouched. So it made me think we could do with something we could manually run when doing merges. I'm not sure having a 'tests' directory in the root seems a bit out of place and confusing for someone looking at the branch. What's your thoughts?

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

What if we simply renamed the folder to specify what it is? Something like checkformat or ? I suppose anything but tests. If so, I'm happy to merge this. Also should we just run flake8?

Revision history for this message
Nicholas Skaggs (nskaggs) :
review: Needs Information
Revision history for this message
Dan Chapman  (dpniel) wrote :

I suppose we could just run flake8 but I have no idea how to configure it, for if we need to exclude certain pyflake errors etc. I'll go take a look through the manual see how it all works

lp://staging/~dpniel/ubuntu-autopilot-tests/add_pyflakes_pep8 updated
65. By Dan Chapman 

Changed folder name as suggested

Revision history for this message
Dan Chapman  (dpniel) wrote :

folder named changed so good to go now :-)

Revision history for this message
Nicholas Skaggs (nskaggs) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches