Ubuntu File Manager App

Merge lp://staging/~dpm/ubuntu-filemanager-app/enable-translations into lp://staging/ubuntu-filemanager-app

  1. enable-translations
  2. Merge into trunk
Proposed by David Planella
Status: Work in progress
Proposed branch: lp://staging/~dpm/ubuntu-filemanager-app/enable-translations
Merge into: lp://staging/ubuntu-filemanager-app
Diff against target: 757 lines (+459/-66)
19 files modified
.bzrignore (+4/-0)
FolderListPage.qml (+7/-6)
FolderListView.qml (+5/-3)
Makefile (+1/-1)
README (+1/-1)
README.translations (+36/-0)
debian/changelog (+6/-0)
debian/control (+8/-7)
debian/filemanager-app-autopilot.install (+1/-1)
debian/filemanager-app.install (+5/-5)
debian/rules (+9/-0)
filemanager-app (+1/-1)
filemanager-app.desktop (+3/-2)
filemanager-app.qml (+2/-2)
filemanager-app.qmlproject (+15/-1)
po/filemanager-app.pot (+311/-0)
po/po.pro (+39/-31)
tests/autopilot/filemanager_app/tests/__init__.py (+4/-4)
tests/autopilot/filemanager_app/tests/test_filemanager.py (+1/-1)
To merge this branch: bzr merge lp://staging/~dpm/ubuntu-filemanager-app/enable-translations
Reviewer Review Type Date Requested Status
Carlos Jose Mazieri Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Review via email: mp+187975@code.staging.launchpad.net

Commit message

Enable the translations infrastructure: expose translations in Launchpad and build/ship them in the Debian package.

Description of the change

NOTE: if you do a review, feel free to approve/disapprove in the comments, but do not top-approve yet, as this needs to be coordinated with the package name change in the seeds.

Enable the translations infrastructure: expose translations in Launchpad and build/ship them in the Debian package.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:69
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/38/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests/499/console
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-precise-amd64-ci/38
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-quantal-amd64-ci/38
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-raring-amd64-ci/38
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-filemanager-app-saucy-amd64-ci/38

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-filemanager-app-ci/38/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Carlos Jose Mazieri (carlos-mazieri) wrote :

It looks good.

review: Approve
Reply

Unmerged revisions

69. By David Planella

Remove unneded files to show in the project, update Debian changelog

68. By David Planella

Added rule to build and install translations

67. By David Planella

Created .pot file, improved some messages to ease translation

66. By David Planella

Do not scan for translations in JavaScript files, the project does not seem to have any

65. By David Planella

Renamed all paths files and code from ubuntu-filemanager-app to filemanager-app for consistency. We want to drop the ubuntu- prefix from all apps progressively, so this might be a good point for the file manager

64. By David Planella

Added basic translations infrastructure

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches