Merge lp://staging/~dpm/reminders-app/debian-copyright into lp://staging/reminders-app

Proposed by David Planella
Status: Work in progress
Proposed branch: lp://staging/~dpm/reminders-app/debian-copyright
Merge into: lp://staging/reminders-app
Diff against target: 34 lines (+20/-0)
1 file modified
debian/copyright (+20/-0)
To merge this branch: bzr merge lp://staging/~dpm/reminders-app/debian-copyright
Reviewer Review Type Date Requested Status
Nicholas Skaggs (community) Needs Fixing
Daniel Holbach (community) Needs Fixing
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Michael Zanetti (community) Approve
Review via email: mp+225646@code.staging.launchpad.net

Commit message

Add copyright information to the Debian packaging, including those files licensed under the Apache-2.0 license

Description of the change

Add copyright information to the Debian packaging, including those files licensed under the Apache-2.0 license

There were a few things I wasn't sure about, it'd be good if someone knowledgeable on licenses would review them:

- There is no information about which year the copyright applies to in the license headers in src/3rdParty/libthrift, thus I've left the year in debian/copyright for that entry blank.
- The files under src/3rdParty/evernote-sdk-cpp were generated automatically by Thrift at Evernote. They have no license information, thus I'm assuming they have the same license as the files under src/3rdParty/libthrift

To post a comment you must log in.
Revision history for this message
Michael Zanetti (mzanetti) wrote :

ack. cheers.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Daniel Holbach (dholbach) wrote :

This is missing the following:

 - tests/autopilot/thrift/*, ./3rdParty/libthrift/: Apache (v2.0)
 - 3rdParty/evernote-sdk-cpp/: BSD (2 clause)

The following files are GPL v3 or later:
./src/app/camerahelper.cpp: GPL (v3 or later)
./src/app/preferences.cpp: GPL (v3 or later)
./src/app/preferences.h: GPL (v3 or later)
./src/app/camerahelper.h: GPL (v3 or later)
./src/app/main.cpp: GPL (v3 or later)

This file is LGPL v3:
./tests/autopilot/reminders/tests/__init__.py

review: Needs Fixing
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :
review: Needs Fixing

Unmerged revisions

175. By David Planella

Added Apache 2.0 license to Debian packaging

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches