Merge lp://staging/~dpitkin/ubuntu-webcatalog/fix-facebook-css into lp://staging/ubuntu-webcatalog

Proposed by David Pitkin
Status: Rejected
Rejected by: Anthony Lenton
Proposed branch: lp://staging/~dpitkin/ubuntu-webcatalog/fix-facebook-css
Merge into: lp://staging/ubuntu-webcatalog
Diff against target: 13 lines (+2/-1)
1 file modified
src/webcatalog/static/css/webcatalog.css (+2/-1)
To merge this branch: bzr merge lp://staging/~dpitkin/ubuntu-webcatalog/fix-facebook-css
Reviewer Review Type Date Requested Status
Danny Tamez Pending
Review via email: mp+107383@code.staging.launchpad.net

Description of the change

Fix the Facebook buttons to align

To post a comment you must log in.
Revision history for this message
Michael Nelson (michael.nelson) wrote :

Hi David! Cool to see you submitting patches :)

I'm just wondering, did you see this facebook mis-align on the trunk branch, or on production/staging? I'd noticed the same mis-align a while ago and done a fly-by fix as part of this branch on 2012-05-04:

https://code.launchpad.net/~michael.nelson/ubuntu-webcatalog/962140-display-video-demos-pt-2/+merge/104714

by adding the height: 24px. That branch hasn't been rolled out to staging or production yet, but afaics, it aligns the base-lines of the widgets like this:

http://people.canonical.com/~michaeln/tmp/2012-05-29-fb-links-on-trunk.png

Here is what I see on production (ie. the mis-align):

http://people.canonical.com/~michaeln/tmp/2012-05-29-fb-links-on-production.png

Here's what I see locally (or on production/staging using developer tools) with your modifications (ie. tops are aligned):

http://people.canonical.com/~michaeln/tmp/2012-05-29-fb-links-on-trunk-with-dpitkin-patch.png

Let me know what you prefer... if you do prefer your patch (tops of the widgets are aligned), I think we'd be better off using vertical-align:top, removing the height that I added all together (ie. https://pastebin.canonical.com/66941/ ), as it aligns the widgets on FF in the same way (where as the current patch doesn't, at least for me, FF12).

Speaking of FF, it looks like the G+ icon is being cropped in FF using our trunk branch (with all of the above solutions). Anyway, I can fix that once you've decided about this current branch.

Unmerged revisions

124. By David Pitkin

Align Facebook Like Buttons

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches