Linaro Fetch Image

Merge lp://staging/~dooferlad/linaro-fetch-image/allow_separte_build_numbers into lp://staging/linaro-fetch-image

  1. allow_separte_build_numbers
  2. Merge into linaro-fetch-image
Proposed by James Tunnicliffe
Status: Merged
Approved by: James Tunnicliffe
Approved revision: 7
Merged at revision: 7
Proposed branch: lp://staging/~dooferlad/linaro-fetch-image/allow_separte_build_numbers
Merge into: lp://staging/linaro-fetch-image
Diff against target: 516 lines (+198/-80)
5 files modified
linaro-fetch-image (+2/-1)
linaro-fetch-image-ui (+93/-45)
linaro_fetch_image/fetch_image.py (+33/-32)
linaro_fetch_image/fetch_image_settings.yaml (+4/-2)
linaro_fetch_image/tests/test_fetch_image.py (+66/-0)
To merge this branch: bzr merge lp://staging/~dooferlad/linaro-fetch-image/allow_separte_build_numbers
Reviewer Review Type Date Requested Status
Paul Sokolovsky Approve
Review via email: mp+95407@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

This is somewhat harder to review than https://code.launchpad.net/~dooferlad/linaro-fetch-image/move_indexer/+merge/95564 . It would be nice if there were more fine-grained commits instead of rev 6, which packs a lot of stuff into single one.

Other comments:

679
                   "be able to select the build number.\n\nThere is no "
680
                   "requirement for the hardware pack and operating systems"
681
                   "to have matching build numbers.")

IMHO sounds a bit too easy on terminology (laymanish?), would be better to use something like "...for the hardware pack and OS image to have..."

Otherwise, taking into account presence of test, Approve.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: