mediaplayer-app

Merge lp://staging/~donquichot2016/mediaplayer-app/pause_focus_fix into lp://staging/mediaplayer-app

  1. pause_focus_fix
  2. Merge into trunk
Proposed by Bosko
Status: Needs review
Proposed branch: lp://staging/~donquichot2016/mediaplayer-app/pause_focus_fix
Merge into: lp://staging/mediaplayer-app
Diff against target: 89 lines (+21/-0)
4 files modified
src/CMakeLists.txt (+3/-0)
src/mediaplayer.cpp (+15/-0)
src/mediaplayer.h (+2/-0)
src/qml/player.qml (+1/-0)
To merge this branch: bzr merge lp://staging/~donquichot2016/mediaplayer-app/pause_focus_fix
Reviewer Review Type Date Requested Status
Renato Araujo Oliveira Filho (community) Needs Fixing
Review via email: mp+295408@code.staging.launchpad.net

Description of the change

This should fix Bug #1518331. The new code uses GSettings to check what mode Unity is running in and doesn't pause when it's in windowed mode.

To post a comment you must log in.
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

Unfortunately due our apps policy click apps does not have access to gsettings, We should not use gsettings for apps.

review: Needs Fixing
Reply
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

maybe the app should not pause when loosing focus. And leave it to unity to suspend it. Could you try it?

Reply
Revision history for this message
Jim Hodapp (jhodapp) wrote :

The video will still play as it's not the app that's technically playing the video but media-hub (media-hub obviously never gets suspended).

Reply

Unmerged revisions

418. By Bosko
417. By Bosko

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: