Merge lp://staging/~donadigo/switchboard/plug-use-search-entry into lp://staging/~elementary-pantheon/switchboard/switchboard
Proposed by
Adam Bieńkowski
| Status: | Rejected |
|---|---|
| Rejected by: | Cody Garver |
| Proposed branch: | lp://staging/~donadigo/switchboard/plug-use-search-entry |
| Merge into: | lp://staging/~elementary-pantheon/switchboard/switchboard |
| Diff against target: |
76 lines (+24/-5) 2 files modified
lib/Plug.vala (+12/-1) src/Switchboard.vala (+12/-4) |
| To merge this branch: | bzr merge lp://staging/~donadigo/switchboard/plug-use-search-entry |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Corentin Noël | Needs Fixing | ||
| Switchboard Hackers | Pending | ||
|
Review via email:
|
|||
Description of the change
Proivde use_search_entry in the Switchboard.Plug abstract class to set switchboard's plug entry sensitive and also search_
Used in shortcuts searching in keyboard plug:
https:/
To post a comment you must log in.
Unmerged revisions
- 557. By Adam Bieńkowski
-
Provide use_search_entry key and search_
entry_changed in library in order to use search entry directly in the plugs
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This does already the job :
public abstract async Gee.TreeMap<string, string> search (string search);
indeed, our client doesn't make use of this right now, but here is how it should work:
* When the search entry is changed, it calls this search function with the search string
* The TreeMap contains some "Keyboard → Behavior → Duration", "keyboard<
So it is up to the client to show the search results, but it's currently not implemented in the client.