Merge lp://staging/~donadigo/slingshot/uninstall-apps into lp://staging/~elementary-pantheon/slingshot/trunk
Proposed by
Adam Bieńkowski
| Status: | Work in progress | ||||
|---|---|---|---|---|---|
| Proposed branch: | lp://staging/~donadigo/slingshot/uninstall-apps | ||||
| Merge into: | lp://staging/~elementary-pantheon/slingshot/trunk | ||||
| Diff against target: |
117 lines (+49/-2) 3 files modified
CMakeLists.txt (+1/-1) src/CMakeLists.txt (+1/-0) src/Widgets/AppEntry.vala (+47/-1) |
||||
| To merge this branch: | bzr merge lp://staging/~donadigo/slingshot/uninstall-apps | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Danielle Foré | Needs Fixing | ||
| Jung-Kyu Park (community) | Approve | ||
| Neal Gompa (community) | Needs Information | ||
|
Review via email:
|
|||
Commit message
* Add uninstall item to app right-click menu to uninstall apps
Description of the change
This branch fixes bug #1211570: "Uninstall apps from context menu in Slingshot".
The implementation is done with appstream, altough on Slack we also talked about a possible implementation depending on Contractor / appstream-glib in the future.
The Gtk.show_uri error is only handeled internally, so there is no warning message shown to the user when the app handling appstream URI couldn't be launched for some reason (definitely should be shown in the future).
Please test, if launching wingpanel doesn't take too much time, because this branch uses heavy AppStream.Pool.load () which could make impact on loading times on logging in first time or launching wingpanel from terminal.
To post a comment you must log in.
Revision history for this message
| Rico Tzschichholz (ricotz) wrote | # |
Revision history for this message
| Adam Bieńkowski (donadigo) wrote | # |
Unmerged revisions
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
If you're going to use AppStream instead of appstream-glib, be sure to target AppStream 0.10 or newer only. There's an API break between 0.9.x and 0.10.x.