Merge lp://staging/~donadigo/scratch/open-dir-sidebar into lp://staging/~elementary-apps/scratch/scratch
Proposed by
Adam Bieńkowski
| Status: | Work in progress | ||||
|---|---|---|---|---|---|
| Proposed branch: | lp://staging/~donadigo/scratch/open-dir-sidebar | ||||
| Merge into: | lp://staging/~elementary-apps/scratch/scratch | ||||
| Diff against target: |
74 lines (+18/-3) 4 files modified
plugins/filemanager/FileManagerPlugin.vala (+5/-0) src/MainWindow.vala (+4/-0) src/Scratch.vala (+7/-3) src/Services/PluginManager.vala (+2/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~donadigo/scratch/open-dir-sidebar | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| elementary Apps team | Pending | ||
|
Review via email:
|
|||
Commit message
* Passing directory will now open it in the sidebar
Description of the change
This branch fixes bug #1570661: "Open directory in sidebar if passed a directory".
If given a directory, Scratch will no longer throw an error, instead it will pass the file through the new "request_
I still don't feel really confident about this solution, and if there should be other changes in the code to perhaps improve handling other directories / arguments etc. Please feel free to ping me on Slack or tell me in a review.
To post a comment you must log in.
Revision history for this message
| Jeremy Wootten (jeremywootten) wrote | # |
Revision history for this message
| Adam Bieńkowski (donadigo) wrote | # |
Unmerged revisions
- 1821. By Adam Bieńkowski
-
Opening directory will now open it in the sidebar
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Will this work or conflict with lp:~matzipan/scratch/folder-manager-improvement?