Additional payment, bank statement and voucher addons for OpenERP

Merge lp://staging/~domsense/account-payment/adding_account_vat_on_payment_7 into lp://staging/~account-payment-team/account-payment/7.0

  1. adding_account_vat_on_payment_7
  2. Merge into 7.0
Proposed by Lorenzo Battistini
Status: Needs review
Proposed branch: lp://staging/~domsense/account-payment/adding_account_vat_on_payment_7
Merge into: lp://staging/~account-payment-team/account-payment/7.0
Diff against target: 816 lines (+770/-0)
9 files modified
account_vat_on_payment/AUTHORS.txt (+1/-0)
account_vat_on_payment/__init__.py (+25/-0)
account_vat_on_payment/__openerp__.py (+60/-0)
account_vat_on_payment/account.py (+433/-0)
account_vat_on_payment/account_view.xml (+104/-0)
account_vat_on_payment/company.py (+42/-0)
account_vat_on_payment/company_view.xml (+21/-0)
account_vat_on_payment/partner.py (+36/-0)
account_vat_on_payment/partner_view.xml (+48/-0)
To merge this branch: bzr merge lp://staging/~domsense/account-payment/adding_account_vat_on_payment_7
Reviewer Review Type Date Requested Status
Lorenzo Battistini (community) Disapprove
Omar (Pexego) code review, no test Approve
Review via email: mp+196914@code.staging.launchpad.net

Description of the change

See 'account_voucher_cash_basis' description.

To activate the VAT on payment behaviour, this module adds a checkbox on
invoice form: 'Vat on payment'

Moreover, three things have to be configured:
 - On account object, Related account used for real registrations on a VAT on
    payment basis
 - On journal object, Related journal used for shadow registrations on a VAT on
    payment basis
 - On tax code object, Related tax code used for real registrations on a VAT on
    payment basis

Requirements:
https://docs.google.com/spreadsheet/ccc?key=0Aodwq17jxF4edDJaZ2dOQkVEN0hodEtfRmpVdlg2Vnc#gid=0
Howto:
http://planet.agilebg.com/en/2012/10/vat-on-payment-treatment-with-openerp/

I propose this now so we can discuss about the usefulness of this module.

I set it 'work in progress' also because YAML tests are missing.

To post a comment you must log in.
Revision history for this message
Davide Corio (enlightx-deactivatedaccount) wrote :

there's a blocking typo here:

http://bazaar.launchpad.net/~domsense/account-payment/adding_account_vat_on_payment_7/view/head:/account_vat_on_payment/account.py#L45

s/vat_on_paymen/vat_on_payment

Reply
Revision history for this message
Lorenzo Battistini (elbati) wrote :

2013/11/27 Davide Corio <email address hidden>

> there's a blocking typo here:
>
>
> http://bazaar.launchpad.net/~domsense/account-payment/adding_account_vat_on_payment_7/view/head:/account_vat_on_payment/account.py#L45
>
> s/vat_on_paymen/vat_on_payment
>
>
Oops.
Fixed.
Thanks!

Reply
Revision history for this message
Omar (Pexego) (omar7r) wrote :

Could you take the time to bring this to the 7.0 community addons coding conventions. This includes:

* not using the shortcut imports (things in the openerp namespace need to be imported from openerp)
* using the from . import xxx for relative imports (typically in __init__.py files)
* using orm.Model and orm.TransientModel as base class rather than osv.osv and osv.osv_memory
* etc.

Thanks

review: Needs Fixing (code review)
Reply
Revision history for this message
Nicola Malcontenti - Agile BG (hurrin1c0) wrote :

Hi Omar,
Thanks for the segnalation,
we have done all the modify requested.

Greetings.
-N.

Reply
Revision history for this message
Lorenzo Battistini (elbati) wrote :

This now depends on
https://code.launchpad.net/~agilebg/account-payment/7.0-bug-1276077-elbati/+merge/204684

Reply
Revision history for this message
Omar (Pexego) (omar7r) wrote :

Thanks, LGTM

review: Approve (code review, no test)
Reply
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

This project is now hosted on https://github.com/OCA/account-payment. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

Reply
Revision history for this message
Lorenzo Battistini (elbati) wrote :

Moved to https://github.com/OCA/account-payment/pull/2

review: Disapprove
Reply

Unmerged revisions

115. By Lorenzo Battistini

[FIX] when selecting partner without fiscal position, do not overwrite invoice field

114. By Lorenzo Battistini

[FIX] [7.0] account_vat_on_payment - impossible to compute VAT based on invoice total in case of write-off

113. By Lorenzo Battistini

[FIX] missing fields

112. By Hurrinico

[FIX] PEP8 fixing

111. By Lorenzo Battistini

[IMP] handling fiscal positions

110. By Lorenzo Battistini

[FIX] typo

109. By Lorenzo Battistini

[fix] URL

108. By Lorenzo Battistini

[imp] other PEP8

107. By Lorenzo Battistini

[imp] other PEP8

106. By Lorenzo Battistini

[IMP] some PEP8

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.