Merge lp://staging/~doctormo/screenlets/options-rework into lp://staging/screenlets
Proposed by
Martin Owens
| Status: | Merged |
|---|---|
| Merged at revision: | 632 |
| Proposed branch: | lp://staging/~doctormo/screenlets/options-rework |
| Merge into: | lp://staging/screenlets |
| Diff against target: |
3868 lines (+2019/-1579) 14 files modified
setup.py (+1/-1) src/lib/__init__.py (+156/-146) src/lib/options.py (+0/-1432) src/lib/options/__init__.py (+202/-0) src/lib/options/account_option.py (+143/-0) src/lib/options/base.py (+624/-0) src/lib/options/boolean_option.py (+54/-0) src/lib/options/colour_option.py (+149/-0) src/lib/options/file_option.py (+179/-0) src/lib/options/font_option.py (+52/-0) src/lib/options/list_option.py (+210/-0) src/lib/options/number_option.py (+90/-0) src/lib/options/string_option.py (+79/-0) src/lib/options/time_option.py (+80/-0) |
| To merge this branch: | bzr merge lp://staging/~doctormo/screenlets/options-rework |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Screenlets Dev Team | Pending | ||
|
Review via email:
|
|||
Description of the change
Reattempt to get merged in updated options. These are API compatible and offer a new colour array option.
To post a comment you must log in.
Revision history for this message
| Märt Põder (boamaod) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
It seems to function generally, but acts a bit differently from the old one. For example text option does not save multiline text (probably it needs to be escaped). If nobody is against it, I think the code should be merged if Martin is willing to work on the code and fix bugs when they appear...