URL Dispatcher

Merge lp://staging/~dobey/url-dispatcher/initial-cpp into lp://staging/url-dispatcher

  1. initial-cpp
  2. Merge into trunk.17.04
Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 118
Merged at revision: 120
Proposed branch: lp://staging/~dobey/url-dispatcher/initial-cpp
Merge into: lp://staging/url-dispatcher
Prerequisite: lp://staging/~dobey/url-dispatcher/use-libwhoopsie
Diff against target: 218 lines (+73/-76)
5 files modified
service/CMakeLists.txt (+1/-1)
service/service.cpp (+37/-43)
tests/url_dispatcher_testability/test_fake_dispatcher.py.in (+7/-1)
tools/CMakeLists.txt (+1/-1)
tools/url-dispatcher.cpp (+27/-30)
To merge this branch: bzr merge lp://staging/~dobey/url-dispatcher/initial-cpp
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
unity-api-1-bot continuous-integration Needs Fixing
Review via email: mp+320201@code.staging.launchpad.net

Commit message

Convert service main process and url-dispatcher tool code to C++.

To post a comment you must log in.
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:118
https://jenkins.canonical.com/unity-api-1/job/lp-url-dispatcher-ci/56/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1822/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1829
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1605
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1605/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1605
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1605/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1605
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1605/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1605
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1605/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1605/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1605/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-url-dispatcher-ci/56/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ted Gould (ted) wrote :

No issue with this code, but I think it might be a good time to introduce the GLib/GObject pointer helpers that Pete wrote. They're not needed here, but we'll want them in future branches anyways.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches