unity-scope-click

Merge lp://staging/~dobey/unity-scope-click/use-libdbustest into lp://staging/unity-scope-click

  1. use-libdbustest
  2. Merge into trunk
Proposed by dobey
Status: Work in progress
Proposed branch: lp://staging/~dobey/unity-scope-click/use-libdbustest
Merge into: lp://staging/unity-scope-click
Diff against target: 855 lines (+469/-49)
10 files modified
CMakeLists.txt (+3/-0)
debian/control (+3/-0)
libclickscope/click/pay.cpp (+2/-0)
libclickscope/tests/CMakeLists.txt (+14/-0)
libclickscope/tests/dbustest.cpp (+276/-0)
libclickscope/tests/dbustest.h (+73/-0)
libclickscope/tests/test_pay.cpp (+43/-19)
scope/clickstore/store-scope.cpp (+15/-14)
scope/tests/CMakeLists.txt (+9/-0)
scope/tests/test_query.cpp (+31/-16)
To merge this branch: bzr merge lp://staging/~dobey/unity-scope-click/use-libdbustest
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Charles Kerr (community) Approve
Review via email: mp+264352@code.staging.launchpad.net

Commit message

Initial usage of dbusmock to improve testing.

To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) wrote :

LGTM.

review: Approve
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:341
http://jenkins.qa.ubuntu.com/job/unity-scope-click-ci/657/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-click-wily-amd64-ci/63/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-click-wily-armhf-ci/59/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-click-ci/657/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:342
http://jenkins.qa.ubuntu.com/job/unity-scope-click-ci/658/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-click-wily-amd64-ci/64
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-click-wily-armhf-ci/60/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-click-ci/658/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:343
http://jenkins.qa.ubuntu.com/job/unity-scope-click-ci/659/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-click-wily-amd64-ci/65
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-click-wily-armhf-ci/61/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-click-ci/659/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Charles Kerr (charlesk) :
review: Approve
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:344
http://jenkins.qa.ubuntu.com/job/unity-scope-click-ci/661/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-click-wily-amd64-ci/67
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-click-wily-armhf-ci/63/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-click-ci/661/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
dobey (dobey) wrote :

This unfortunately seems to be exposing some serious bugs in lp:dbus-test-runner (at least, the crashes seem to point there), when these tests get run on 32-bit archs. I don't know how the tests in pay-service aren't constantly crashing, to be honest. All of the stuff which is being done via libdbustest really needs to be done in memory, rather than spawning a dbus-daemon with a socket on disk and multiple python3 processes for the mocked services.

Reply

Unmerged revisions

344. By dobey

No, use the static constexpr instead.

343. By dobey

Because strings and formatting are a horrible pain.

342. By dobey

Add python3-dbusmock to work around dependency issue.

341. By dobey

Merge trunk.

340. By dobey

Move start-up details into start() for click scope.

339. By dobey

Add dependency on libdbustest.
Add testcase abstraction for dbus mocking.
Add mocks for pay-service dbus API.
Set up the PayPackage on object creation.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: