unity-scope-click

Merge lp://staging/~dobey/unity-scope-click/review-crash into lp://staging/unity-scope-click

  1. review-crash
  2. Merge into trunk
Proposed by dobey
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 405
Merged at revision: 405
Proposed branch: lp://staging/~dobey/unity-scope-click/review-crash
Merge into: lp://staging/unity-scope-click
Diff against target: 96 lines (+37/-2)
4 files modified
libclickscope/click/reviews.cpp (+7/-2)
libclickscope/click/webclient.cpp (+5/-0)
libclickscope/click/webclient.h (+1/-0)
libclickscope/tests/test_reviews.cpp (+24/-0)
To merge this branch: bzr merge lp://staging/~dobey/unity-scope-click/review-crash
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Paweł Stołowski (community) Approve
Review via email: mp+283544@code.staging.launchpad.net

Commit message

Only try to parse the JSON when we get a 200.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:404
http://jenkins.qa.ubuntu.com/job/unity-scope-click-ci/691/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-click-wily-amd64-ci/95/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-click-wily-armhf-ci/91/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-click-ci/691/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Paweł Stołowski (stolowski) wrote :

+ qCritical() << "Status:" << status;

Should use qDebug(), no need to spam our logs with criticals on every reply.

Otherwise looking good.

review: Needs Fixing
lp://staging/~dobey/unity-scope-click/review-crash updated
405. By dobey

Remove the leftover debug log message.

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Looks good, thanks!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:405
http://jenkins.qa.ubuntu.com/job/unity-scope-click-ci/697/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-click-wily-amd64-ci/101/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-click-wily-armhf-ci/97/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-click-ci/697/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: