Merge lp://staging/~dobey/ubuntuone-windows-installer/add-data into lp://staging/ubuntuone-windows-installer

Proposed by dobey
Status: Merged
Approved by: Brian Curtin
Approved revision: 142
Merged at revision: 139
Proposed branch: lp://staging/~dobey/ubuntuone-windows-installer/add-data
Merge into: lp://staging/ubuntuone-windows-installer
Diff against target: 205 lines (+52/-18)
7 files modified
.bzrignore (+3/-0)
scripts/conf.py (+3/-0)
scripts/data/macapp_template.plist (+0/-2)
scripts/devsetup/buildout.cfg (+3/-2)
scripts/setup-mac.py (+15/-1)
scripts/setup.py (+25/-10)
scripts/ubuntuone.xml (+3/-3)
To merge this branch: bzr merge lp://staging/~dobey/ubuntuone-windows-installer/add-data
Reviewer Review Type Date Requested Status
Brian Curtin (community) Approve
Mike McCracken (community) Approve
Review via email: mp+124509@code.staging.launchpad.net

Commit message

Pull ubuntuone-client-data as a source now.
Grab the win and mac icons from ubuntuone-client-data.
Include the ubuntuone-client-data revno in revnos.txt.

Description of the change

This changes where the icon comes from, so please build test installers of this if you can, and ensure the icon is getting bundled correctly still.

To post a comment you must log in.
140. By dobey

Use self.source_dir in setup-mac

141. By dobey

Update conf.py as well, and include proper usage of it

142. By dobey

Don't grab the sp revno here as we don't know it yet

Revision history for this message
Mike McCracken (mikemc) wrote :

Looks good, works for me on darwin

review: Approve
Revision history for this message
Brian Curtin (brian.curtin) wrote :

Looks good on Windows.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches