Merge lp://staging/~dobey/ubuntuone-installer/update-from-trunk into lp://staging/ubuntuone-installer/stable-3-0

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: no longer in the source branch.
Merged at revision: 33
Proposed branch: lp://staging/~dobey/ubuntuone-installer/update-from-trunk
Merge into: lp://staging/ubuntuone-installer/stable-3-0
Diff against target: 73 lines (+22/-8)
2 files modified
ubuntuone/installer/__init__.py (+2/-0)
ubuntuone/installer/gui.py (+20/-8)
To merge this branch: bzr merge lp://staging/~dobey/ubuntuone-installer/update-from-trunk
Reviewer Review Type Date Requested Status
Eric Casteleijn (community) Approve
Natalia Bidart (community) Approve
Review via email: mp+96207@code.staging.launchpad.net

Commit message

Only install packages that haven't yet been installed.
Use gettext.install so gettext will return unicode objects instead of bytes.

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Looks good.

review: Approve
29. By dobey

Only install packages that haven't yet been installed.
Use gettext.install so gettext will return unicode objects instead of bytes.

Revision history for this message
Eric Casteleijn (thisfred) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: