Ubuntu One Client

Merge lp://staging/~dobey/ubuntuone-client/fix-576263-stable into lp://staging/ubuntuone-client/stable-1-2

  1. fix-576263-stable
  2. Merge into stable-1-2
Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 513
Merged at revision: 516
Proposed branch: lp://staging/~dobey/ubuntuone-client/fix-576263-stable
Merge into: lp://staging/ubuntuone-client/stable-1-2
Diff against target: 31 lines (+4/-7)
1 file modified
bin/ubuntuone-preferences (+4/-7)
To merge this branch: bzr merge lp://staging/~dobey/ubuntuone-client/fix-576263-stable
Reviewer Review Type Date Requested Status
Roman Yepishev (community) Approve
Natalia Bidart (community) Approve
Review via email: mp+26310@code.staging.launchpad.net

Commit message

Avoid opening the error dialog when getting devices list

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Tests must be provided for this feature.

If this is a backport from trunk, the tests should be backported as well. If there are no tests in trunk for this change, those should be added and then backported.

review: Needs Fixing
Revision history for this message
dobey (dobey) wrote :

Bug for needing tests: https://bugs.edge.launchpad.net/ubuntuone-client/+bug/589896

Revision history for this message
Natalia Bidart (nataliabidart) :
review: Approve
Revision history for this message
Roman Yepishev (rye) wrote :

Dialog does not appear anymore.
However I will file a bug regarding the actions that should be done by the software if user removes all tokens via the web interface.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: