Merge lp://staging/~dobey/ubuntuone-client-gnome/no-more-eds into lp://staging/ubuntuone-client-gnome
Proposed by
dobey
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Approved by: | dobey | ||||||||
| Approved revision: | 25 | ||||||||
| Merged at revision: | 19 | ||||||||
| Proposed branch: | lp://staging/~dobey/ubuntuone-client-gnome/no-more-eds | ||||||||
| Merge into: | lp://staging/ubuntuone-client-gnome | ||||||||
| Diff against target: |
2122 lines (+55/-1919) 14 files modified
configure.ac (+1/-1) nautilus/Makefile.am (+0/-31) nautilus/add-contact-dialog.c (+0/-137) nautilus/add-contact-dialog.h (+0/-50) nautilus/contacts-view.c (+0/-855) nautilus/contacts-view.h (+0/-81) nautilus/highlight.c (+0/-162) nautilus/highlight.h (+0/-29) nautilus/share-dialog.c (+54/-52) nautilus/test-contacts-picker.c (+0/-98) nautilus/test-highlight.c (+0/-90) nautilus/u1-contacts-picker.c (+0/-269) nautilus/u1-contacts-picker.h (+0/-61) po/POTFILES.in (+0/-3) |
||||||||
| To merge this branch: | bzr merge lp://staging/~dobey/ubuntuone-client-gnome/no-more-eds | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brian Curtin (community) | Approve | ||
| Roberto Alsina (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Remove usage of libebook and e-d-s for contact lookup.
Use a simple entry field for sharing to e-mail addresses.
Description of the change
This updates the Nautilus extension to no longer have the large contact picker that was empty for most people, and removes the usage of e-d-s for contacts lookup, as the new version in 12.10 has broken API/ABI compatibility. Instead, there is now a simple entry for entering one or more e-mail addresses (using comma separation of course).
In testing this branch, I discovered a crash in libsyncdaemon when entering multiple e-mail addresses, and so to share with multiple addresses successfully, lp:~dobey/ubuntuone-client/fix-1043868 will also be needed.
A screen shot of this change is at http://
To post a comment you must log in.
Revision history for this message
| Roberto Alsina (ralsina) | # |
review:
Approve
Revision history for this message
| Brian Curtin (brian.curtin) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Design suggests changing the text to "Email addresses, comma separated" so users know what to enter.