Merge lp://staging/~dobey/ubuntu/precise/avahi/bring-back-gir into lp://staging/ubuntu/precise/avahi

Proposed by dobey
Status: Work in progress
Proposed branch: lp://staging/~dobey/ubuntu/precise/avahi/bring-back-gir
Merge into: lp://staging/ubuntu/precise/avahi
Diff against target: 85 lines (+39/-0)
4 files modified
debian/changelog (+8/-0)
debian/control (+27/-0)
debian/gir1.2-avahi-0.6.install (+2/-0)
debian/libavahi-gobject-dev.install (+2/-0)
To merge this branch: bzr merge lp://staging/~dobey/ubuntu/precise/avahi/bring-back-gir
Reviewer Review Type Date Requested Status
Michael Terry Needs Fixing
Ubuntu branches Pending
Review via email: mp+80103@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

I tried building this in a pbuilder and got:

make[5]: *** No rule to make target `AvahiCore-0.6.typelib', needed by `all-am'. Stop.

review: Needs Fixing
Revision history for this message
dobey (dobey) wrote :

Apparently libgirepository-dev doesn't pull in gobject-introspection, so had to add that too.

Revision history for this message
Michael Terry (mterry) wrote :

Shouldn't AvahiCore.gir be in libavahi-core-dev instead of libavahi-gobject-dev? And a similar split for the gir1.2-* packages right?

Revision history for this message
dobey (dobey) wrote :

When they were packaged from the old gir-repository package before, they were both in gir1.0-avahi-0.6, with the .gir files in gir-repository-dev.

Also, in the source tree, they are both under the avahi-gobject/ directory, and gobject-introspection still requires libgobject to work, even though libavahi-core doesn't. So the gobject-dev package seems to be the most appropriate place in the avahi binary packaging.

Oh, I just realized though. I guess I probably need to Conflicts/Replaces gir-repository-dev from the libavahi-gobject-dev package as well, no?

Revision history for this message
Colin Watson (cjwatson) wrote :

If you're moving files from one package to another (even if there was a
period when the files were in neither package), please use
Breaks/Replaces rather than Conflicts/Replaces.

Revision history for this message
Michael Terry (mterry) wrote :

I still disagree that it makes sense to bundle the bindings. They have different namespaces and different associated libraries. True, you'll need gobject-introspection to understand the gir, but that is a different thing than needing libavahi-gobject. Imagine an app that only wants to use libavahi-core.

But maybe we need a third opinion.

110. By dobey

Use Breaks/Replaces for the old gir-repository packages

Revision history for this message
dobey (dobey) wrote :

Well, glib, GTK, GStreamer, and Pango aren't split up in that way for the various different libraries they install, and this preserves the way they used to be packaged in debian from gir-repository. It doesn't seem appropriate, and an app only using avahi-core I think is more likely to use the available static bindings, than use gobject-introspection without also using the GObject-based API.

It seems the manually created AvahiCore-0.6.gir only exists to satisfy the dependency needs of the auto-generated Avahi-0.6.gir. Also, it /is/ Avahi-0.6.gir and not AvahiGObject-0.6.gir, which suggests that for using avahi with gobject-introspection, one really should be using Avahi, and not AvahiCore.

Revision history for this message
dobey (dobey) wrote :

Also, AvahiCore-0.6.gir only includes a few type definitions, and one single function, so probably not useful to use by itself. :)

Revision history for this message
Michael Terry (mterry) wrote :

An update on this: since Debian hasn't included the girs yet, I agree that it doesn't make sense to innovate around the naming ourselves. So I'm OK with the naming for now. But I did notice that when built, the typelib files get put in a multiarch location, which Python does not pick up. That should be looked into.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Could you send your patch to Debian as well? It would be better if they reviewed and merged it there and spare us to have to decide on the binaries to use and the naming

Revision history for this message
Sebastien Bacher (seb128) wrote :

Rodney, could you send it to debian?

Revision history for this message
Stéphane Graber (stgraber) wrote :

No activity from author for a months. Please answer the questions above and mark the branch as needs merging again.

Thanks

Unmerged revisions

110. By dobey

Use Breaks/Replaces for the old gir-repository packages

109. By dobey

Also need gobject-introspection in build-depends

108. By dobey

Add gir1.2-glib-2.0 to build-depends also

107. By dobey

Add bug to changelog

106. By dobey

* Bring back the gir interface for Avahi
  - gir1.2-avahi-0.6: package for Avahi gir typelibs
  - libavahi-gobject-dev: include the .gir for Avahi

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: