Ubuntu
banshee package

Merge lp://staging/~dobey/ubuntu/oneiric/banshee/faster-u1ms-loading into lp://staging/ubuntu/oneiric/banshee

Proposed by dobey on 2011-10-24

Status:

Merged

Merge reported by:

Merged at revision:

not available

Proposed branch:

lp://staging/~dobey/ubuntu/oneiric/banshee/faster-u1ms-loading

Merge into:

lp://staging/ubuntu/oneiric/banshee

Diff against target:

137 lines (+91/-2)

5 files modified

debian/changelog (+9/-0)
debian/control (+2/-2)
debian/patches/91_u1ms_switch_faster.patch (+54/-0)
debian/patches/92_avoid_source_race.patch (+24/-0)
debian/patches/series (+2/-0)

To merge this branch:

bzr merge lp://staging/~dobey/ubuntu/oneiric/banshee/faster-u1ms-loading

Related bugs:

Bug #872972: Store URLs have to wait for main page to load	High	Fix Released
Bug #882732: Race Condition setting active source at startup	High	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Ubuntu branches		2011-10-24	Pending
Review via email: mp+80259@code.staging.launchpad.net

Revision history for this message

Michael Terry (mterry) wrote on 2011-10-25:

#

I looked into this. After this and the libubuntuone patch [1], starting banshee with a u1ms url doesn't switch to the music store after startup. dobey is looking into it.

[1] https://code.launchpad.net/~dobey/ubuntu/oneiric/libubuntuone/faster-u1ms/+merge/80260

Revision history for this message

dobey (dobey) wrote on 2011-10-26:

#

This seems to be a race condition internal to banshee as best I can tell. When attempting to debug using banshee from git, the problem went away, and I can no longer replicate it. I'm not sure how to further debug that specific issue, either, as it appears to be a Heisenbug. :-/

lp://staging/~dobey/ubuntu/oneiric/banshee/faster-u1ms-loading updated on 2011-10-27

130. By dobey on 2011-10-27: Backport patch to avoid race condition using idle handler (LP: #882732)

Revision history for this message

dobey (dobey) wrote on 2011-10-27:

#

Just pushed up with a new patch to also fix bug #872972 (the race) as well.

Revision history for this message

dobey (dobey) wrote on 2011-10-27:

#

Sorry, bug #882732 is the race. Not 872972.

Revision history for this message

Michael Terry (mterry) wrote on 2011-10-27:

#

Awesome, works great now. Pushed to oneiric-proposed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Ubuntu branches

dobey