Merge lp://staging/~dobey/ubuntu-sso-client/no-more-ping into lp://staging/ubuntu-sso-client
Proposed by
dobey
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Approved by: | dobey | ||||||||
| Approved revision: | 1040 | ||||||||
| Merged at revision: | 1038 | ||||||||
| Proposed branch: | lp://staging/~dobey/ubuntu-sso-client/no-more-ping | ||||||||
| Merge into: | lp://staging/ubuntu-sso-client | ||||||||
| Diff against target: |
361 lines (+18/-182) 11 files modified
ubuntu_sso/constants.py.in (+3/-8) ubuntu_sso/networkstate/darwin.py (+1/-1) ubuntu_sso/networkstate/tests/run_nwmgr_standalone.py (+1/-1) ubuntu_sso/qt/current_user_sign_in_page.py (+1/-5) ubuntu_sso/qt/email_verification_page.py (+1/-5) ubuntu_sso/qt/sso_wizard_page.py (+1/-2) ubuntu_sso/qt/tests/test_current_user_sign_in_page.py (+3/-19) ubuntu_sso/qt/tests/test_email_verification.py (+3/-22) ubuntu_sso/utils/__init__.py (+1/-33) ubuntu_sso/utils/tests/test_common.py (+1/-84) ubuntu_sso/utils/webclient/timestamp.py (+2/-2) |
||||||||
| To merge this branch: | bzr merge lp://staging/~dobey/ubuntu-sso-client/no-more-ping | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Natalia Bidart (community) | Approve | ||
| dobey (community) | Abstain | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2014-08-13.
Commit message
Remove the ping URL usage.
Update the Terms and Privacy URLs to point to login.ubuntu.com.
Update timestamp checking URL to point to login.ubuntu.com.
To post a comment you must log in.
Revision history for this message
| dobey (dobey) | # |
review:
Abstain
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
/home/dobey/
39: 'defer' imported but unused
47: 'compat' imported but unused
47: 'webclient' imported but unused
/home/dobey/
43: 'EMAIL' imported but unused
43: 'TOKEN' imported but unused