Merge lp://staging/~dobey/u1sync/use-dirspec into lp://staging/u1sync

Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 7
Merged at revision: 6
Proposed branch: lp://staging/~dobey/u1sync/use-dirspec
Merge into: lp://staging/u1sync
Diff against target: 29 lines (+6/-3)
1 file modified
u1sync/client.py (+6/-3)
To merge this branch: bzr merge lp://staging/~dobey/u1sync/use-dirspec
Reviewer Review Type Date Requested Status
Brian Curtin (community) Approve
Manuel de la Peña (community) Approve
Review via email: mp+111480@code.staging.launchpad.net

Commit message

Get the log dir from the platform logger module

Description of the change

To post a comment you must log in.
Revision history for this message
Brian Curtin (brian.curtin) :
review: Approve
Revision history for this message
Manuel de la Peña (mandel) :
review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

The attempt to merge lp:~dobey/u1sync/use-dirspec into lp:u1sync failed. Below is the output from the failed tests.

u1sync
  tests
    test_client ... [ERROR]
u1sync.tests.test_merge
  MergeTest
    test_clobber ... [OK]
    test_generic_merge ... [OK]
    test_sync ... [OK]

===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/twisted/trial/runner.py", line 572, in loadPackage
    module = modinfo.load()
  File "/usr/lib/python2.7/dist-packages/twisted/python/modules.py", line 383, in load
    return self.pathEntry.pythonPath.moduleLoader(self.name)
  File "/usr/lib/python2.7/dist-packages/twisted/python/reflect.py", line 464, in namedAny
    topLevelPackage = _importAndCheckStack(trialname)
  File "/mnt/tarmac/cache/u1sync/trunk/u1sync/tests/test_client.py", line 23, in <module>
    from u1sync import client
  File "/mnt/tarmac/cache/u1sync/trunk/u1sync/client.py", line 35, in <module>
    from ubuntuone.platform.logger import ubuntuone_log_dir
exceptions.ImportError: No module named logger

u1sync.tests.test_client
-------------------------------------------------------------------------------
Ran 4 tests in 0.148s

FAILED (errors=1, successes=3)

ERROR:root:Could not find any typelib for Unity

Revision history for this message
Manuel de la Peña (mandel) :
review: Approve
Revision history for this message
Brian Curtin (brian.curtin) :
review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

The attempt to merge lp:~dobey/u1sync/use-dirspec into lp:u1sync failed. Below is the output from the failed tests.

u1sync
  tests
    test_client ... [ERROR]
u1sync.tests.test_merge
  MergeTest
    test_clobber ... [OK]
    test_generic_merge ... [OK]
    test_sync ... [OK]

===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/twisted/trial/runner.py", line 572, in loadPackage
    module = modinfo.load()
  File "/usr/lib/python2.7/dist-packages/twisted/python/modules.py", line 383, in load
    return self.pathEntry.pythonPath.moduleLoader(self.name)
  File "/usr/lib/python2.7/dist-packages/twisted/python/reflect.py", line 464, in namedAny
    topLevelPackage = _importAndCheckStack(trialname)
  File "/usr/lib/python2.7/dist-packages/twisted/python/reflect.py", line 400, in _importAndCheckStack
    return __import__(importName)
  File "/mnt/tarmac/cache/u1sync/trunk/u1sync/tests/test_client.py", line 23, in <module>
    from u1sync import client
  File "/mnt/tarmac/cache/u1sync/trunk/u1sync/client.py", line 67, in <module>
    handler = RotatingFileHandler(LOGFILENAME)
  File "/usr/lib/python2.7/logging/handlers.py", line 118, in __init__
    BaseRotatingHandler.__init__(self, filename, mode, encoding, delay)
  File "/usr/lib/python2.7/logging/handlers.py", line 65, in __init__
    logging.FileHandler.__init__(self, filename, mode, encoding, delay)
  File "/usr/lib/python2.7/logging/__init__.py", line 897, in __init__
    StreamHandler.__init__(self, self._open())
  File "/usr/lib/python2.7/logging/__init__.py", line 916, in _open
    stream = open(self.baseFilename, self.mode)
exceptions.IOError: [Errno 2] No such file or directory: '/mnt/tarmac/.cache/u1sync/log/u1sync.log'

u1sync.tests.test_client
-------------------------------------------------------------------------------
Ran 4 tests in 0.065s

FAILED (errors=1, successes=3)

ERROR:root:Could not find any typelib for Unity

7. By dobey

Fix the tests

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: