pay-ui

Merge lp://staging/~dobey/pay-ui/escape-signed-query into lp://staging/pay-ui

escape-signed-query
Merge into first-branch

Proposed by dobey on 2015-10-29

Status:

Merged

Approved by:

dobey on 2015-11-27

Approved revision:

136

Merged at revision:

138

Proposed branch:

lp://staging/~dobey/pay-ui/escape-signed-query

Merge into:

lp://staging/pay-ui

Diff against target:

76 lines (+20/-3)

3 files modified

backend/modules/payui/network.cpp (+11/-3)
backend/modules/payui/network.h (+1/-0)
backend/tests/test_network.cpp (+8/-0)

To merge this branch:

bzr merge lp://staging/~dobey/pay-ui/escape-signed-query

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Charles Kerr (community)		2015-10-29	Approve on 2015-11-24
PS Jenkins bot (community)	continuous-integration		Approve on 2015-11-23
Review via email: mp+276191@code.staging.launchpad.net

Commit message

Encode slashes in URL query strings when signing as a query.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-10-30:

PASSED: Continuous integration, rev:135
http://jenkins.qa.ubuntu.com/job/pay-ui-ci/145/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-14.09-touch/21
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-14.09-armhf/43
    SUCCESS: http://jenkins.qa.ubuntu.com/job/pay-ui-14.09-armhf-ci/5
        deb: http://jenkins.qa.ubuntu.com/job/pay-ui-14.09-armhf-ci/5/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/941
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-14.09-armhf/44
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/24733

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/pay-ui-ci/145/rebuild

review: Approve (continuous-integration)

Revision history for this message

Charles Kerr (charlesk) wrote on 2015-10-30:

I'm not sure that this does what we need. QUrl::setQuery appears to only check StrictMode in order to clear out the query if validation fails (http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/io/qurl.cpp#n2618) so instead of encoding the slash in auth_signature wouldn't this just clear the query altogether?