The Sound Menu

Merge lp://staging/~dobey/indicator-sound/no-more-autostart into lp://staging/indicator-sound

  1. no-more-autostart
  2. Merge into trunk.16.10
Proposed by dobey
Status: Merged
Approved by: dobey
Approved revision: 546
Merged at revision: 546
Proposed branch: lp://staging/~dobey/indicator-sound/no-more-autostart
Merge into: lp://staging/indicator-sound
Diff against target: 85 lines (+1/-59)
4 files modified
data/CMakeLists.txt (+0/-41)
data/indicator-sound.desktop.in (+0/-9)
data/indicator-sound.upstart.desktop.in (+0/-9)
debian/indicator-sound.maintscript (+1/-0)
To merge this branch: bzr merge lp://staging/~dobey/indicator-sound/no-more-autostart
Reviewer Review Type Date Requested Status
Xavi Garcia Approve
unity-api-1-bot continuous-integration Needs Fixing
Review via email: mp+316503@code.staging.launchpad.net

Commit message

Remove old autostart files.

To post a comment you must log in.
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:546
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-sound-ci/6/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1610/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1617
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1395/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1395/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1395/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1395/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1395/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1395/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-sound-ci/6/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:546
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-sound-ci/7/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1613/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1620
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1398/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1398/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1398/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1398/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1398/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1398/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-sound-ci/7/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
dobey (dobey) wrote :

Looks like something weird is causing integration tests to fail in Jenkins. I'm not sure if this indicator ever passed those tests in Jenkins, at this point though. The tests pass locally, but there does appear to be some flakiness as I get a single failure out of maybe 30 runs or so.

Revision history for this message
Xavi Garcia (xavi-garcia-mena) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches