The Sound Menu

Merge lp://staging/~dobey/indicator-sound/drop-greeeter into lp://staging/indicator-sound

  1. drop-greeeter
  2. Merge into trunk.16.10
Proposed by dobey
Status: Approved
Approved by: dobey
Approved revision: 552
Proposed branch: lp://staging/~dobey/indicator-sound/drop-greeeter
Merge into: lp://staging/indicator-sound
Diff against target: 867 lines (+4/-697)
11 files modified
debian/control (+0/-1)
src/CMakeLists.txt (+2/-20)
src/accounts-service-user.vala (+0/-47)
src/greeter-broadcast.vala (+0/-34)
src/main.c (+2/-6)
src/media-player-list-greeter.vala (+0/-123)
src/media-player-user.vala (+0/-18)
src/service.vala (+0/-9)
tests/CMakeLists.txt (+0/-51)
tests/greeter-list.cc (+0/-68)
tests/media-player-user.cc (+0/-320)
To merge this branch: bzr merge lp://staging/~dobey/indicator-sound/drop-greeeter
Reviewer Review Type Date Requested Status
unity-api-1-bot continuous-integration Approve
Charles Kerr (community) Approve
Review via email: mp+320858@code.staging.launchpad.net

Commit message

Strip out the complicated non-working greeter support.

Description of the change

This removes the code which theoretically proxies the player controls out to the greeter screen, that doesn't work.

The Sound menu spec states that the player controls should NOT appear on the greeter screen:

https://wiki.ubuntu.com/Sound#Music_player_sections
"Whenever you are logged in (that is, not in the standalone installer session or at the login screen), any music player that advertises itself over http://mpris.org/ Mpris should have its own section in the sound menu."

To post a comment you must log in.
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:552
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-sound-ci/14/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1858/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1865
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1641/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1641/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1641/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1641/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1641/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1641/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-sound-ci/14/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Charles Kerr (charlesk) wrote :

So, first off, I'm not super happy with the tone of the MR, e.g. "theoretically". If the code needs fixing then that's something that should be addressed, but bugs happen and there's no need to be snide about it.

Secondly, I still disagree with the removal of this feature. Controlling play from the greeter is a worthwhile feature IMO.

But as per the discussion in the Indicator meeting today, I'm in the minority on this. If neither the coder doing the work, NOR the designer, want this feature, I'm not going to block the change. :P

review: Approve
Reply
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:552
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-sound-ci/24/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1892
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1899
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1681
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1681/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1681
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1681/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1681
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1681/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1681
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1681/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1681
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1681/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1681
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1681/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-sound-ci/24/rebuild

review: Approve (continuous-integration)
Reply

Unmerged revisions

552. By dobey

Strip out the complicated non-working greeter support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches