Merge lp://staging/~doanac/ubuntu-ci-services-itself/run-worker-called-process into lp://staging/ubuntu-ci-services-itself
Proposed by
Andy Doan
| Status: | Merged |
|---|---|
| Approved by: | Andy Doan |
| Approved revision: | 371 |
| Merged at revision: | 372 |
| Proposed branch: | lp://staging/~doanac/ubuntu-ci-services-itself/run-worker-called-process |
| Merge into: | lp://staging/ubuntu-ci-services-itself |
| Diff against target: |
105 lines (+54/-9) 2 files modified
ci-utils/ci_utils/amqp_worker.py (+18/-9) ci-utils/ci_utils/tests/test_amqp_worker.py (+36/-0) |
| To merge this branch: | bzr merge lp://staging/~doanac/ubuntu-ci-services-itself/run-worker-called-process |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Vincent Ladeuil (community) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
run-worker: add generic handling for CalledProcessError
This is for the image-builder, but I think we can do this in the
base class to be useful for everyone. While doing this, I
relocated the error-handling logic of the run-worker into its own
method to help pyflakes not complain about the complexity of the method
Description of the change
Solves part 1 of:
https:/
by adding better error logging for the run-worker.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:371
http://
Executed test runs:
Click here to trigger a rebuild:
http://