Ubuntu CI Services

Merge lp://staging/~doanac/ubuntu-ci-services-itself/ppa-assigner-juju-fix into lp://staging/ubuntu-ci-services-itself

  1. ppa-assigner-juju-fix
  2. Merge into trunk
Proposed by Andy Doan
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 31
Merged at revision: 36
Proposed branch: lp://staging/~doanac/ubuntu-ci-services-itself/ppa-assigner-juju-fix
Merge into: lp://staging/ubuntu-ci-services-itself
Diff against target: 17 lines (+2/-1)
1 file modified
juju-deployer/ppa-assigner.yaml (+2/-1)
To merge this branch: bzr merge lp://staging/~doanac/ubuntu-ci-services-itself/ppa-assigner-juju-fix
Reviewer Review Type Date Requested Status
Vincent Ladeuil (community) Approve
Review via email: mp+198993@code.staging.launchpad.net

Commit message

configure a default LP user for the ppa-assigner in the juju deployer

also fixes a typo/bug for the dependencies

Description of the change

configure a default LP user for the ppa-assigner in the juju deployer

also fixes a typo/bug for the dependencies

To post a comment you must log in.
Revision history for this message
Vincent Ladeuil (vila) wrote :

We can't add comments in yaml files right ?

/me sighs

review: Approve
Revision history for this message
Joe Talbott (joetalbott) wrote :

On Mon, Dec 16, 2013 at 01:11:54PM -0000, Vincent Ladeuil wrote:
> Review: Approve
>
> We can't add comments in yaml files right ?

Sure we can. '#' is the comment character.

Revision history for this message
Vincent Ladeuil (vila) wrote :

Ha cool, then can we document the config options ? ;) (What is the config format that refuses comments then ?)

Revision history for this message
Andy Doan (doanac) wrote :

On 12/16/2013 08:25 AM, Vincent Ladeuil wrote:
> Ha cool, then can we document the config options ? ;) (What is the config format that refuses comments then ?)

JSON is the format that doesn't allow comments.

NOTE: config options are documented in each juju charm. For example, the
options i'm using in this MP are documented here:

<http://bazaar.launchpad.net/~canonical-ci-engineering/charms/precise/python-django/ci-services/view/head:/config.yaml>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches