Merge lp://staging/~doanac/ubuntu-ci-services-itself/json-status-styling into lp://staging/ubuntu-ci-services-itself

Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 311
Merged at revision: 321
Proposed branch: lp://staging/~doanac/ubuntu-ci-services-itself/json-status-styling
Merge into: lp://staging/ubuntu-ci-services-itself
Diff against target: 260 lines (+106/-21)
9 files modified
branch-source-builder/bsbuilder/resources/v1.py (+4/-4)
branch-source-builder/bsbuilder/tests/test_v1.py (+8/-2)
ci-utils/ci_utils/json_status.py (+49/-0)
image-builder/imagebuilder/resources/v1.py (+4/-4)
ppa-assigner/ppa_assigner/api.py (+12/-6)
ppa-assigner/ppa_assigner/tests.py (+4/-2)
test_runner/tstrun/resources/v1.py (+11/-0)
test_runner/tstrun/tests/test_v1.py (+6/-0)
webui/webui_status.js (+8/-3)
To merge this branch: bzr merge lp://staging/~doanac/ubuntu-ci-services-itself/json-status-styling
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Joe Talbott (community) Approve
Review via email: mp+209352@code.staging.launchpad.net

Commit message

improve display logic of json-status objects

This gets the providers sending information in a better format
that the webui can start to style better.

NOTE: this doesn't address make the webui look nice. It just
gets the backend pieces in place so that webui can now be improved
upon independently

Description of the change

This changes the json_status API to use a fixed style response so the webui can make better decisions on how to display the data. I've only done minimal work to the webui so it can process the data format. I'd like to have the webui improvements be a separate MP built on this.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:310
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/295/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/295/rebuild

review: Approve (continuous-integration)
Revision history for this message
Joe Talbott (joetalbott) wrote :

L55 remove 2013 I think

L254 s/!=/!==/

L260 not needed I think

Otherwise +1

Revision history for this message
Andy Doan (doanac) wrote :

On 03/06/2014 09:39 AM, Joe Talbott wrote:
> L55 remove 2013 I think

I'll fix this.

> L254 s/!=/!==/

I think you meant L242. Regardless:

<https://code.launchpad.net/~doanac/ubuntu-ci-services-itself/json-datatables/+merge/209506>

removes all the ugly stuff, so I'd rather just merge with this ugliness
for now if you don't mind?

>
> L260 not needed I think

ditto for this.

311. By Andy Doan

correct copyright date

Revision history for this message
Joe Talbott (joetalbott) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:311
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/310/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/310/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches