Merge lp://staging/~doanac/ubuntu-ci-services-itself/deployment-variables into lp://staging/ubuntu-ci-services-itself
Proposed by
Andy Doan
Status: | Merged |
---|---|
Approved by: | Andy Doan |
Approved revision: | 252 |
Merged at revision: | 258 |
Proposed branch: | lp://staging/~doanac/ubuntu-ci-services-itself/deployment-variables |
Merge into: | lp://staging/ubuntu-ci-services-itself |
Diff against target: |
169 lines (+56/-30) 4 files modified
juju-deployer/deploy.py (+28/-21) juju-deployer/test_deploy.py (+15/-0) tests/ppa_assigner/test.py (+12/-8) tests/run.py (+1/-1) |
To merge this branch: | bzr merge lp://staging/~doanac/ubuntu-ci-services-itself/deployment-variables |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andy Doan (community) | Approve | ||
Vincent Ladeuil (community) | Approve | ||
Paul Larson | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email:
|
Commit message
deploy: make a clear list of required environment variables to user
This change makes a consistent single place to enumerate the
environment variables required for deployment. These should ideally
just be added to novarc files.
NOTE: the CI_OAUTH_* and CI_LAUNCHPAD_USER values don't exist in
novarc by default and must be created manually. Please read:
Description of the change
This helps move us to where we can all deploy unique production-ready environments by just having the proper novarc file in place.
To post a comment you must log in.
note: revno 251 is almost orthogonal to this MP, but was discovered as a result of the changes this MP adds.