Merge lp://staging/~doanac/ubuntu-ci-services-itself/bsbuilder-ticket-id into lp://staging/ubuntu-ci-services-itself

Proposed by Andy Doan
Status: Merged
Approved by: Andy Doan
Approved revision: 342
Merged at revision: 343
Proposed branch: lp://staging/~doanac/ubuntu-ci-services-itself/bsbuilder-ticket-id
Merge into: lp://staging/ubuntu-ci-services-itself
Diff against target: 93 lines (+12/-4)
5 files modified
branch-source-builder/bsbuilder/resources/v1.py (+3/-1)
branch-source-builder/bsbuilder/tests/test_v1.py (+2/-0)
docs/components/branch-source-builder.rst (+5/-2)
juju-deployer/branch-source-builder.yaml.tmpl (+1/-1)
lander/bin/lander_service_wrapper.py (+1/-0)
To merge this branch: bzr merge lp://staging/~doanac/ubuntu-ci-services-itself/bsbuilder-ticket-id
Reviewer Review Type Date Requested Status
Vincent Ladeuil (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+210074@code.staging.launchpad.net

Commit message

bsbuilder: add ticket_id as parameter

This is prep-work to make some follow-on changes easier to
understand. The image-builder and test-runner already use ticket_id
as a parameter and the bsbuilder worker will soon need this ability
as well.

I'm doing this up-front to keep the follow-up diffs easier to
comprehend. I also did some minimal updates of the bsbuilder docs.

Description of the change

This is a pre-work MP to get the bsbuilder in a place where follow-on MPs will be eaiser to understand. Currently the image-builder and test-runner are using the ticket-id for their run-worker scripts (needed for storing log artifacts in swift). This passes the parameter down to the worker. I've got some other code that will take advantage of this.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:342
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/347/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/347/rebuild

review: Approve (continuous-integration)
Revision history for this message
Vincent Ladeuil (vila) wrote :

Consistency is good, let's have more ;)

review: Approve
Revision history for this message
Ursula Junque (ursinha) wrote :

I think I'm late to the party, but I was wondering: bsbuilder currently builds source packages, that correspond to subtickets, not tickets. Wouldn't it be correct if the parameter referenced subticket_id instead?

Revision history for this message
Andy Doan (doanac) wrote :

On 03/10/2014 01:56 AM, Ursula Junque wrote:
> I think I'm late to the party, but I was wondering: bsbuilder currently builds source packages, that correspond to subtickets, not tickets. Wouldn't it be correct if the parameter referenced subticket_id instead?

It *should* be but isn't:

  https://bugs.launchpad.net/ubuntu-ci-services-itself/+bug/1285802

So I once that gets working we should pass both the ticket-id and
subticket-id I think.

Revision history for this message
Francis Ginther (fginther) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches